-
Notifications
You must be signed in to change notification settings - Fork 151
[CC-33024] Remove the deprecated fields of CockroachDB operator #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prafull01
wants to merge
1
commit into
cockroachdb:master
Choose a base branch
from
prafull01:remove-deprecated-fields
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -168,14 +168,6 @@ cockroachdb: | |
| clusterSettings: ~ | ||
| # timestamp captures the annotation timestamp used for rolling restarts. | ||
| timestamp: "2021-10-18T00:00:00Z" | ||
| # resources captures the resource requests and limits for CockroachDB pods. | ||
| resources: ~ | ||
| # limits: | ||
| # cpu: 4000m | ||
| # memory: 16Gi | ||
| # requests: | ||
| # cpu: 4000m | ||
| # memory: 16Gi | ||
| # dataStore captures the disk configuration for CockroachDB storage. | ||
| dataStore: | ||
| # volumeClaimTemplate captures the PVC template for storage. | ||
|
|
@@ -282,16 +274,13 @@ cockroachdb: | |
| # storageClassName: "" | ||
| # | ||
| # path is the absolute mount path inside the CockroachDB container to use for WAL failover side disk. | ||
| # Examples: | ||
| # Examples: | ||
| # - /cockroach/cockroach-failover | ||
| # - /cockroach/custom/path | ||
| # IMPORTANT: Set it only for fresh deployments. Changing it on upgrades might cause issues with the deployment. | ||
| # | ||
| # path: "/cockroach/cockroach-failover" | ||
| # | ||
| # podLabels captures additional labels to apply to CockroachDB pods. | ||
| podLabels: | ||
| app.kubernetes.io/component: cockroachdb | ||
| # startFlags specify the flags that will be used for starting the cluster. | ||
| # Any flag defined in here will take precedence over the first-class | ||
| # fields responsible for setting the same flags. | ||
|
|
@@ -303,25 +292,8 @@ cockroachdb: | |
| # # omit defines a set of flags which will be omitted from the start command. | ||
| # omit: | ||
| # - "" | ||
| # env captures environment variables set on CockroachDB pods. | ||
| env: [] | ||
| # - name: APP_NAME | ||
| # value: "CRDB" | ||
| # - name: POD_NAME | ||
| # valueFrom: | ||
| # fieldRef: | ||
| # fieldPath: metadata.name | ||
| # rollingRestartDelay specifies the delay between rolling restarts of CockroachDB pods. | ||
| rollingRestartDelay: 30s | ||
| # topologySpreadConstraints captures pod topology spread constraints. | ||
| # It is recommended to spread CockroachDB pods across zones to ensure high availability. | ||
| topologySpreadConstraints: | ||
| # maxSkew defines the degree to which the pods can be unevenly distributed. | ||
| - maxSkew: 1 | ||
| # topologyKey defines the key for topology spread. | ||
| topologyKey: topology.kubernetes.io/zone | ||
| # whenUnsatisfiable defines the behavior when constraints cannot be met. | ||
| whenUnsatisfiable: DoNotSchedule | ||
| # service captures the Kubernetes Service configurations for CockroachDB pods. | ||
| service: | ||
| # ports captures the service port definitions. | ||
|
|
@@ -368,43 +340,6 @@ cockroachdb: | |
| ingressClassName: "" | ||
| annotations: {} | ||
| host: "" | ||
| # podAnnotations captures annotations to apply to CockroachDB pods. | ||
| podAnnotations: {} | ||
| # terminationGracePeriod determines the time available to CockroachDB for graceful drain. | ||
| # It follows the metav1.Duration format, e.g., "300s", "5m" or "1h". | ||
| # terminationGracePeriod: "300s" | ||
| # nodeSelector captures the node selector labels for scheduling pods. | ||
| nodeSelector: {} | ||
| # affinity captures scheduling affinity rules for CockroachDB pods. | ||
| affinity: | ||
| # nodeAffinity: | ||
| # requiredDuringSchedulingIgnoredDuringExecution: | ||
| # nodeSelectorTerms: | ||
| # - matchExpressions: | ||
| # - key: kubernetes.io/os | ||
| # operator: In | ||
| # values: | ||
| # - linux | ||
| # podAffinity: | ||
| # requiredDuringSchedulingIgnoredDuringExecution: | ||
| # - labelSelector: | ||
| # matchExpressions: | ||
| # - key: security | ||
| # operator: In | ||
| # values: | ||
| # - S1 | ||
| # topologyKey: topology.kubernetes.io/zone | ||
| # podAntiAffinity: | ||
| # preferredDuringSchedulingIgnoredDuringExecution: | ||
| # - weight: 100 | ||
| # podAffinityTerm: | ||
| # labelSelector: | ||
| # matchExpressions: | ||
| # - key: security | ||
| # operator: In | ||
| # values: | ||
| # - S2 | ||
| # topologyKey: topology.kubernetes.io/zone | ||
| # | ||
| # sideCars captures the configuration for sidecar containers. | ||
| sideCars: | ||
|
|
@@ -414,8 +349,6 @@ cockroachdb: | |
| containers: [] | ||
| # volumes captures additional volumes for CockroachDB pods. | ||
| volumes: [] | ||
| # tolerations captures the tolerations for scheduling CockroachDB pods. | ||
| tolerations: [] | ||
| # localityLabels captures labels used to determine node locality. | ||
| # It is an ordered, comma-separated list of keys that which must be present as labels on the nodes. | ||
| # For region and zone to be part of the locality, the labels (topology.kubernetes.io/region, topology.kubernetes.io/region) must be set on the nodes. | ||
|
|
@@ -470,23 +403,83 @@ cockroachdb: | |
| # podTemplate is an optional pod specification that overrides the default pod specification configured by the operator. | ||
| # If specified, podTemplate is merged with the default pod specification, with settings in podTemplate taking precedence. | ||
| # This can be used to add or update containers, volumes, and other settings of the CockroachDB pod. | ||
| podTemplate: {} | ||
| # # metadata captures the pod metadata for CockroachDB pods. | ||
| # metadata: {} | ||
| # # spec captures the pod specification for CockroachDB pods. | ||
| # spec: | ||
| # # initContainers captures the list of init containers for CockroachDB pods. | ||
| # initContainers: | ||
| # - name : cockroachdb-init | ||
| # image: us-docker.pkg.dev/cockroach-cloud-images/data-plane/init-container@sha256:c3e4ba851802a429c7f76c639a64b9152d206cebb31162c1760f05e98f7c4254 | ||
| # # containers captures the list of containers for CockroachDB pods. | ||
| # containers: | ||
| # - name: cockroachdb | ||
| # image: cockroachdb/cockroach:v25.2.2 | ||
| # - name: cert-reloader | ||
| # image: us-docker.pkg.dev/cockroach-cloud-images/data-plane/inotifywait:87edf086db32734c7fa083a62d1055d664900840 | ||
| # # imagePullSecrets captures the secrets for fetching images from private registries. | ||
| # imagePullSecrets: [] | ||
| podTemplate: | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: need to fix the indentation (of comments) within the podTemplate section.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done |
||
| # metadata captures the pod metadata for CockroachDB pods. | ||
| metadata: | ||
| labels: | ||
| app.kubernetes.io/component: cockroachdb | ||
| annotations: {} | ||
| # spec captures the pod specification for CockroachDB pods. | ||
| spec: | ||
| # imagePullSecrets captures the secrets for fetching images from private registries. | ||
| # imagePullSecrets: [] | ||
| # initContainers captures the list of init containers for CockroachDB pods. | ||
| # initContainers: | ||
| # - name : cockroachdb-init | ||
| # image: us-docker.pkg.dev/cockroach-cloud-images/data-plane/init-container@sha256:c3e4ba851802a429c7f76c639a64b9152d206cebb31162c1760f05e98f7c4254 | ||
| # containers captures the list of containers for CockroachDB pods. | ||
| containers: | ||
| - name: cockroachdb | ||
| # env captures environment variables set on CockroachDB pods. | ||
| env: [] | ||
| # - name: APP_NAME | ||
| # value: "CRDB" | ||
| # - name: POD_NAME | ||
| # valueFrom: | ||
| # fieldRef: | ||
| # fieldPath: metadata.name | ||
| resources: {} | ||
| # image: cockroachdb/cockroach:v25.2.2 | ||
| # - name: cert-reloader | ||
| # image: us-docker.pkg.dev/cockroach-cloud-images/data-plane/inotifywait:87edf086db32734c7fa083a62d1055d664900840 | ||
|
|
||
| # topologySpreadConstraints captures pod topology spread constraints. | ||
| # It is recommended to spread CockroachDB pods across zones to ensure high availability. | ||
| topologySpreadConstraints: | ||
| # maxSkew defines the degree to which the pods can be unevenly distributed. | ||
| - maxSkew: 1 | ||
| # topologyKey defines the key for topology spread. | ||
| topologyKey: topology.kubernetes.io/zone | ||
| # whenUnsatisfiable defines the behavior when constraints cannot be met. | ||
| whenUnsatisfiable: DoNotSchedule | ||
| # terminationGracePeriodSeconds determines the time available to CockroachDB for graceful drain. | ||
| # terminationGracePeriodSeconds: 300 | ||
| # tolerations captures the tolerations for pods of the self-signer job. | ||
| # https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/ | ||
| # tolerations: [] | ||
pritesh-lahoti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # nodeSelector captures the node selector labels for scheduling pods. | ||
| # nodeSelector: {} | ||
pritesh-lahoti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # affinity captures scheduling affinity rules for CockroachDB pods. | ||
| # affinity: | ||
pritesh-lahoti marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| # nodeAffinity: | ||
| # requiredDuringSchedulingIgnoredDuringExecution: | ||
| # nodeSelectorTerms: | ||
| # - matchExpressions: | ||
| # - key: kubernetes.io/os | ||
| # operator: In | ||
| # values: | ||
| # - linux | ||
| # podAffinity: | ||
| # requiredDuringSchedulingIgnoredDuringExecution: | ||
| # - labelSelector: | ||
| # matchExpressions: | ||
| # - key: security | ||
| # operator: In | ||
| # values: | ||
| # - S1 | ||
| # topologyKey: topology.kubernetes.io/zone | ||
| # podAntiAffinity: | ||
| # preferredDuringSchedulingIgnoredDuringExecution: | ||
| # - weight: 100 | ||
| # podAffinityTerm: | ||
| # labelSelector: | ||
| # matchExpressions: | ||
| # - key: security | ||
| # operator: In | ||
| # values: | ||
| # - S2 | ||
| # topologyKey: topology.kubernetes.io/zone | ||
| # | ||
|
|
||
| # persistentVolumeClaimRetentionPolicy is used to Retain or Delete the PVCs when the node is deleted. | ||
| # If not specified, the PVCs will be deleted when the node is deleted. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| dependencies: | ||
| - name: operator | ||
| repository: file://charts/operator | ||
| version: 25.3.4-preview | ||
| version: 25.3.4-preview+1 | ||
| - name: cockroachdb | ||
| repository: file://charts/cockroachdb | ||
| version: 25.3.4-preview | ||
| digest: sha256:3183216d170059cfb2f456d2bfacf8f4a5cd72cb0da9669e52545ac038111180 | ||
| generated: "2025-10-30T16:40:55.519890932Z" | ||
| version: 25.3.4-preview+1 | ||
| digest: sha256:d0a6019097a776a1a0957da0d00639856a5d16a61b826fec25d184f5cfedcfc0 | ||
| generated: "2025-10-31T00:56:21.004226+05:30" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to rewrite this description? Seems like it's not actually optional since now it contains the default pod specifications.