sql: keep feature detail in plpgsql unimplemented telemetry#171342
Closed
rafiss wants to merge 1 commit into
Closed
sql: keep feature detail in plpgsql unimplemented telemetry#171342rafiss wants to merge 1 commit into
rafiss wants to merge 1 commit into
Conversation
The plpgsql parser reports syntax-level "unimplemented" errors via the lexer's UnimplementedWithIssue helper, which keys telemetry on the tracking issue number alone (e.g. "cockroachdb#169572"). This drops the per-feature breakdown, so a single issue's hits can no longer be attributed to the specific syntax that produced them. Switch to unimp.NewWithIssueDetail, mirroring the main SQL parser's UnimplementedWithIssueDetail helper. Each call site passes a short, stable feature identifier as the telemetry detail, so the key becomes "#<issue>.<detail>" (e.g. "cockroachdb#169572.alias for") while still linking to the issue. The rendered error message is unchanged. Epic: CRDB-63280 Release note: None Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The plpgsql parser reports syntax-level "unimplemented" errors via the lexer's UnimplementedWithIssue helper, which keys telemetry on the tracking issue number alone (e.g. "#169572"). This drops the per-feature breakdown, so a single issue's hits can no longer be attributed to the specific syntax that produced them.
Switch to unimp.NewWithIssueDetail, mirroring the main SQL parser's UnimplementedWithIssueDetail helper. Each call site passes a short, stable feature identifier as the telemetry detail, so the key becomes "#." (e.g. "#169572.alias for") while still linking to the issue. The rendered error message is unchanged.
Epic: CRDB-63280
Release note: None