Skip to content

sql: fix FETCH FIRST on empty WITH HOLD cursor #171337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rail merged 1 commit into from
Jun 10, 2026
Merged

sql: fix FETCH FIRST on empty WITH HOLD cursor #171337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions pkg/sql/logictest/testdata/logic_test/cursor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,3 +943,20 @@ statement ok
CLOSE foo;

subtest end

# Regression test for FETCH FIRST on a persisted WITH HOLD cursor over an
# empty result set returning an internal error instead of zero rows (#171238).
subtest regression_171238

statement ok
BEGIN;
DECLARE foo_first CURSOR WITH HOLD FOR SELECT * FROM empty;
COMMIT;

query empty
FETCH FIRST FROM foo_first;

statement ok
CLOSE foo_first;

subtest end
4 changes: 2 additions & 2 deletions pkg/sql/sql_cursor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,8 +288,8 @@ func (b *fetchMoveNodeBase) nextInternal(ctx context.Context) (bool, error) {
case tree.FetchFirst:
switch b.cursor.curRow {
case 0:
_, err := b.cursor.Next(ctx)
return true, err
more, err := b.cursor.Next(ctx)
return more, err
case 1:
return true, nil
}
Expand Down
Loading