changefeedccl: add file-based OAuth client assertion support#171223
changefeedccl: add file-based OAuth client assertion support#171223KeithCh wants to merge 3 commits into
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
7924262 to
19a275a
Compare
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
19a275a to
1abad9d
Compare
1abad9d to
eabd669
Compare
eabd669 to
d9bc921
Compare
AI Review: Potential Issue(s) DetectedInline comments have been added to the relevant lines in Summary: The PR accidentally deletes the If helpful: add |
bae5f70 to
b37afc9
Compare
…ry flag Add infrastructure for node-local subsystems to read credential files from a single operator-bounded directory. Example: cockroach start --secret-directory=/etc/cockroach/secrets ... Release note: None Epic: CRDB-62004 Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
b37afc9 to
a67c7e8
Compare
BuildContext is an extension point on saslMechanismBuilder for passing resources beyond URI params, letting individual mechanisms pull their own dependencies without dispatcher-level special-casing. Today it carries a *secretdir.Reader, which exposes credential files from the directory configured by the --secret-directory node flag. Release note: None Epic: CRDB-62004 Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
a67c7e8 to
5a2160f
Compare
Add sasl_proprietary_client_assertion_location URI parameter for Kafka changefeeds to reference a file-based OAuth client assertion. e.g. ``` CREATE CHANGEFEED FOR t INTO 'kafka://.../?sasl_proprietary_client_assertion_location=/path/to/jwt' ``` The path needs to be an absolute path. All nodes should have the --secret-directory flag set to the same directory. Users need the EXTERNALIOIMPLICITACCESS privilege to use create changefeeds that use file-based OAuth client assertions. Exactly one of sasl_proprietary_client_assertion_location or sasl_proprietary_client_assertion should be set when using PROPRIETARY_OAUTH. Release note: None Epic: CRDB-62004 Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
5a2160f to
94589c6
Compare
security/secretdir: add jailed credential reader and --secret-directory flag
Add infrastructure for node-local subsystems to read credential
files from a single operator-bounded directory.
Example:
cockroach start --secret-directory=/etc/cockroach/secrets ...
changefeedccl: thread BuildContext through saslMechanismBuilder
BuildContext is an extension point on saslMechanismBuilder for
passing resources beyond URI params, letting individual mechanisms
pull their own dependencies without dispatcher-level special-casing.
Today it carries a *secretdir.Reader, which exposes credential
files from the directory configured by the --secret-directory node
flag.
changefeedccl: add file-based OAuth client assertion support
Add sasl_proprietary_client_assertion_location URI parameter for Kafka changefeeds to reference a file-based OAuth client assertion.
e.g.
The path needs to be an absolute path.
All nodes should have the --secret-directory flag set to the same directory. Users need the EXTERNALIOIMPLICITACCESS privilege to use create changefeeds that use file-based OAuth client assertions. Exactly one of sasl_proprietary_client_assertion_location or sasl_proprietary_client_assertion should be set when using PROPRIETARY_OAUTH.
Release note: None
Epic: CRDB-62004