release-26.2: ui: move TimezoneProvider to be inside RequiredLogin#169786
release-26.2: ui: move TimezoneProvider to be inside RequiredLogin#169786kyle-a-wong wants to merge 1 commit intocockroachdb:release-26.2from
Conversation
Fixes a bug where the login page was making a request for cluster settings in order to create the timezone provider context. This request results in a 401 unauthorized since users need to be authorized to request cluster setting data. In version before 26.3, this bug made it impossible to login as a non default tenant via OIDC login, since this unauthorized response caused tenant cookies to be cleared before user could click the OIDC button. Epic: None Release note: None
|
Thanks for opening a backport. Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate. |
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Before this PR: |
Backport 1/1 commits from #169751 on behalf of @kyle-a-wong.
/cc @cockroachdb/release
Fixes a bug where the login page was making a request for cluster settings in order to create the timezone provider context. This request results in a 401 unauthorized since users need to be authorized to request cluster setting data. In version before 26.3, this bug made it impossible to login as a non default tenant via OIDC login, since this unauthorized response caused tenant cookies to be cleared before user could click the OIDC button.
Epic: None
Release note: None
Release justification: Fix for a bug that prevents non-default tenant OIDC login