release-24.3: ui: move TimezoneProvider to be inside RequiredLogin#169782
Draft
kyle-a-wong wants to merge 1 commit intocockroachdb:release-24.3from
Draft
release-24.3: ui: move TimezoneProvider to be inside RequiredLogin#169782kyle-a-wong wants to merge 1 commit intocockroachdb:release-24.3from
kyle-a-wong wants to merge 1 commit intocockroachdb:release-24.3from
Conversation
Fixes a bug where the login page was making a request for cluster settings in order to create the timezone provider context. This request results in a 401 unauthorized since users need to be authorized to request cluster setting data. In version before 26.3, this bug made it impossible to login as a non default tenant via OIDC login, since this unauthorized response caused tenant cookies to be cleared before user could click the OIDC button. Epic: None Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
Thanks for opening a backport. Before merging, please confirm that it falls into one of the following categories (select one):
Add a brief release justification to the PR description explaining your selection. Also, confirm that the change does not break backward compatibility and complies with all aspects of the backport policy. All backports must be reviewed by the TL and EM for the owning area. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #169751 on behalf of @kyle-a-wong.
/cc @cockroachdb/release
Fixes a bug where the login page was making a request for cluster settings in order to create the timezone provider context. This request results in a 401 unauthorized since users need to be authorized to request cluster setting data. In version before 26.3, this bug made it impossible to login as a non default tenant via OIDC login, since this unauthorized response caused tenant cookies to be cleared before user could click the OIDC button.
Epic: None
Release note: None
Release justification: Fix for a bug that prevents non-default tenant OIDC login