sql: remove redundant ALTER TYPE ... SET SCHEMA event logging#169780
Merged
trunk-io[bot] merged 1 commit intocockroachdb:masterfrom May 6, 2026
Merged
Conversation
Contributor
|
😎 Merged successfully - details. |
Member
|
This change is |
rafiss
approved these changes
May 5, 2026
Collaborator
rafiss
left a comment
rafiss
left a comment
There was a problem hiding this comment.
nice find! i question why we even have a specific set_schema event, but since it was there before, i'm not going to argue for changing it right now.
bghal
force-pushed
the
alter-type-set-schema-legacy-event-log
branch
from
b78e3a0 to
538a98d
Compare
The schemachanger was logging a general `alter_type` event and a particular `set_schema` event. This change removes the duplicative logging. Part of: cockroachdb#164216 See: cockroachdb#57741 Supports: cockroachdb#168255 Epic: CRDB-31325 Release note: None
bghal
force-pushed
the
alter-type-set-schema-legacy-event-log
branch
from
538a98d to
c1fd698
Compare
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
Contributor
Author
|
/trunk merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The schemachanger was logging a general
alter_typeevent and aparticular
set_schemaevent. This change removes the duplicativelogging.
Part of: #164216
See: #57741
Supports: #168255
Epic: CRDB-31325
Release note: None