storage: add inline put and del for raft log writes#169771
Draft
pav-kv wants to merge 2 commits intocockroachdb:masterfrom
Draft
storage: add inline put and del for raft log writes#169771pav-kv wants to merge 2 commits intocockroachdb:masterfrom
pav-kv wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Add MVCCBlindPutInline (and MVCCBlindPutInlineProto), a distilled version of MVCCBlindPut for non-transactional inline blind writes. This strips away all unused machinery from the ~580-line mvccPutInternal code path: iterators, lock table scanning, transactions, versioned keys, conflict detection, lock acquisition, valueFn, and logical ops. Wire up raft log appends, truncated state writes, and hard state writes to use the new function. Epic: none Release note: None Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Member
|
This change is |
Add MVCCDeleteInline, a distilled version of MVCCDelete for inline (unversioned) values. It reads the existing value size for stats accounting, then issues ClearUnversioned — bypassing the full mvccPutInternal path with its lock table scanning, transaction handling, and versioned value logic. Wire up the raft log append path (which deletes overwritten log entries) to use the new function. Epic: none Release note: None Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pav-kv
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MVCCBlindPutInline (and MVCCBlindPutInlineProto), a distilled version of MVCCBlindPut for non-transactional inline blind writes. This strips away all unused machinery from the ~580-line mvccPutInternal code path: iterators, lock table scanning, transactions, versioned keys, conflict detection, lock acquisition, valueFn, and logical ops.
Wire up raft log appends, truncated state writes, and hard state writes to use the new function.
Epic: none
Release note: None