inspect: remove complex key configurability#169768
Open
bghal wants to merge 1 commit intocockroachdb:masterfrom
Open
inspect: remove complex key configurability#169768bghal wants to merge 1 commit intocockroachdb:masterfrom
bghal wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Nightly testing has established that the complex key uniqueness check is cheaper than the simple keys so this defensive configuration is cleaned up. See also: cockroachdb#164948 Epic: CRDB-58692 Part of: cockroachdb#154551 Release note: None
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
|
Detected infrastructure failure (matched: self-hosted runner lost communication with the server). Automatically rerunning failed jobs. (run link) |
spilchen
approved these changes
May 6, 2026
Contributor
spilchen
left a comment
spilchen
left a comment
There was a problem hiding this comment.
@spilchen made 2 comments.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on bghal and michae2).
pkg/sql/inspect/uniqueness_check.go line 31 at r1 (raw file):
) var uniquenessCheckComplexKeysEnabled = settings.RegisterBoolSetting(
nit: we should retire this cluster setting rather than just remove it (see retiredSettings)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly testing has established that the complex key uniqueness check
is cheaper than the simple keys so this defensive configuration is
cleaned up.
See also: #164948
Epic: CRDB-58692
Part of: #154551
Release note: None