opt: add PlanGramMismatchPenalty cost penalty flag#169717
Open
michae2 wants to merge 2 commits intocockroachdb:masterfrom
Open
opt: add PlanGramMismatchPenalty cost penalty flag#169717michae2 wants to merge 2 commits intocockroachdb:masterfrom
michae2 wants to merge 2 commits intocockroachdb:masterfrom
Conversation
Contributor
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Member
|
This change is |
Collaborator
Author
|
First commit is #169197 and can be ignored. |
Implement ParsePlanGram, a recursive-descent parser with 1-token lookahead for plangram grammars. The parser reads from an io.Reader using bufio.Scanner with a custom SplitFunc. A reverse-lookup function OperatorByCamelCase is added to the optgen code generator to map camel-case operator names (e.g. "InnerJoin") back to opt.Operator values during parsing. Informs: cockroachdb#152053 Release note: None Co-Authored-By: roachdev-claude <[email protected]>
Add a new PlanGramMismatchPenalty to the cost penalty bitmask. This penalty will be applied when a plan does not match the required PlanGram pattern. Its precedence is stronger than UnboundedCardinalityPenalty but weaker than FullScanPenalty, so that inline hints (which set FullScanPenalty or HugeCostPenalty) take precedence over PlanGram matching. Informs: cockroachdb#152053 Release note: None Co-Authored-By: roachdev-claude <[email protected]>
michae2
force-pushed
the
plangram-mismatch-penalty
branch
from
9154815 to
1760f15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new PlanGramMismatchPenalty to the cost penalty bitmask. This penalty will be applied when a plan does not match the required PlanGram pattern. Its precedence is stronger than UnboundedCardinalityPenalty but weaker than FullScanPenalty, so that inline hints (which set FullScanPenalty or HugeCostPenalty) take precedence over PlanGram matching.
Informs: #152053
Release note: None
Co-Authored-By: roachdev-claude [email protected]