go.mod: bump Pebble to 951fae603dfe #156747
Merged
+29
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
Update code to use the new metrics. EnvStats now includes the blob file count (see cockroachdb#156746). Changes: * [`951fae60`](cockroachdb/pebble@951fae60) metrics: redesign disk usage metrics * [`9e6937d2`](cockroachdb/pebble@9e6937d2) db: add validation for WALFailover options Release note: none. Epic: none.
RaduBerinde
force-pushed
the
radu/pebble-master-951fae603dfe
branch
from
c05af14 to
71d7360
Compare
jbowens
approved these changes
Nov 3, 2025
There was a problem hiding this comment.
@jbowens reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Nov 3, 2025
156487: catalog: add support reading metadata for leased descriptors and add logic test config r=fqazi a=fqazi We recently added an option for using leased descriptors for pg_catalog / crdb_internal tables. While this option can fetch descriptor data, we presently have no way of reading metadata for leased descriptors, such as zone configs and comments. This patch introduces a new option to support reading metadata along with leased descriptors when using the GetAll.* APIs. This patch also adds a new logic test config for testing out using leased descriptors for pg_catalog / crdb_internal logic tests. Fixes: #156404 Release note: None 156688: bulkutil: add utiliy to manage and reuse ExternalStorage instances r=spilchen a=spilchen Adds a new ExternalStorageMux utility that manages and caches cloud.ExternalStorage instances keyed by their base URI (e.g. nodelocal://1/, s3://bucket/). The mux provides a lightweight layer that allows the processors for distribute merge to reuse existing storage connections instead of creating a new ExternalStorage for every file operation. Each ExternalStorageMux maintains a per-processor cache of open storage handles. If a request is made for a URI with a previously seen base prefix, the mux returns the cached handle; otherwise, it lazily creates and tracks a new one. The ExternalStorageMux struct is not thread safe. It doesn't use mutex to control state. It's expected that the consumer won't be using this across multiple goroutines. Closes #156587 Epic: CRDB-48845 Release notes: none 156747: go.mod: bump Pebble to 951fae603dfe r=RaduBerinde a=RaduBerinde Update code to use the new metrics. EnvStats now includes the blob file count (see #156746). Changes: * [`951fae60`](cockroachdb/pebble@951fae60) metrics: redesign disk usage metrics * [`9e6937d2`](cockroachdb/pebble@9e6937d2) db: add validation for WALFailover options Release note: none. Epic: none. Co-authored-by: Faizan Qazi <[email protected]> Co-authored-by: Matt Spilchen <[email protected]> Co-authored-by: Radu Berinde <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update code to use the new metrics. EnvStats now includes the blob
file count (see #156746).
Changes:
951fae60metrics: redesign disk usage metrics9e6937d2db: add validation for WALFailover optionsRelease note: none.
Epic: none.