Add grpc connection closing error to allowlist #156729
Open
+1
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. Before a member of our team reviews your PR, I have some potential action items for you:
🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
andyyang890
reviewed
Nov 4, 2025
| `the client connection is closing`, | ||
| } | ||
| shouldIgnoreErr := func(err error) bool { | ||
| if err == nil || errors.Is(err, context.Canceled) { |
There was a problem hiding this comment.
Would adding grpcutil.IsContextCanceled(err) (or maybe grpcutil.IsClosedConnection(err)?) here work instead? I think the latter would def include this case since it checks for is closing as a substring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix TestChangefeedFlushesSinkToReleaseMemory test flake
Fixes #156078
The test was failing because it encountered a grpc error "the client connection is closing" during connection teardown, which wasn't in the error allowlist. This is a normal cancellation error that should be ignored, similar to the existing "context canceled" entry.
Added the error pattern to the
requireNoFeedsFailhelper's ignore list.Changed:
pkg/ccl/changefeedccl/helpers_test.go: Addedthe client connection is closingto ignoreErrs list