Skip to content

Conversation

@mw5h
Copy link
Contributor

@mw5h mw5h commented Oct 27, 2025

As part of the QA effort for LTREE data, add additional logic test cases:

  • remaining comparison operators
  • defaults and check constraints
  • schema changes
  • views and computed columns
  • usage in UDFs
  • sorting behavior
  • use in composite indexes
  • type casting edge cases and boundary conditions

Informs: #44657
Release notes: none

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@mw5h mw5h requested review from a team and michae2 and removed request for a team October 27, 2025 17:44
Copy link
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: Awesome!

@michae2 reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @mw5h)

As part of the QA effort for LTREE data, add additional logic test
cases:

- remaining comparison operators
- defaults and check constraints
- schema changes
- views and computed columns
- usage in UDFs
- sorting behavior
- use in composite indexes
- type casting edge cases and boundary conditions

Informs: cockroachdb#44657
Release notes: none
@blathers-crl
Copy link

blathers-crl bot commented Oct 27, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@mw5h
Copy link
Contributor Author

mw5h commented Oct 28, 2025

bors r+

@craig
Copy link
Contributor

craig bot commented Oct 28, 2025

@craig craig bot merged commit cc5d7c7 into cockroachdb:master Oct 28, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants