workload: enable rangefeed with --changefeed #155804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenyihu6
requested review from
golgeek,
stevendanna and
williamchoe3
and removed request for
a team
Member
|
This change is |
stevendanna
reviewed
Oct 22, 2025
Comment on lines
89
to
90
| log.Dev.Infof(ctx, "cursor: %s", cursorStr) | ||
|
|
Collaborator
There was a problem hiding this comment.
This seems duplicative of some of the log lines below.
Comment on lines
57
to
59
| if _, err := conn.Exec(ctx, "SET CLUSTER SETTING kv.rangefeed.enabled = true"); err != nil { | ||
| return err | ||
| } |
Collaborator
There was a problem hiding this comment.
This is going to fail if run against a secondary tenant.
Maybe before trying to set it, we could check if it is already set. The check should work in a secondary tenant and secondary tenants generally will have rangefeeds enabled.
Contributor
Author
There was a problem hiding this comment.
TIL - is this because of
or something else? Changed it so that it only tries to enable if not enabled already.
Comment on lines
135
to
136
| if epoch, parseErr := strconv.ParseInt(cursorStr, 10, 64); parseErr == nil { | ||
| t := time.Unix(epoch, 0).UTC() |
Collaborator
There was a problem hiding this comment.
Might be better to use hlc.ParseHLC here?
Contributor
Author
There was a problem hiding this comment.
Dropped this commit. Going to add it as part of #156276.
This commit enables rangefeed when the --changefeed flag is specified with the workload command.
stevendanna
approved these changes
Oct 27, 2025
Contributor
Author
|
TFTR! bors r+ |
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit enables rangefeed when the --changefeed flag is specified with the
workload command.
Epic: https://cockroachlabs.atlassian.net/browse/CRDB-55203
Release note: none