Skip to content

release-25.4: pgwire: make max repeated error count configurable via cluster setting #155658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 20, 2025
Merged

release-25.4: pgwire: make max repeated error count configurable via cluster setting #155658

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fbd3c7
pgwire: lower the max repeated error count before closing a connection
rafiss Oct 7, 2025
5b51f74
pgwire: make max repeated error count configurable via cluster setting
rafiss Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/sql/pgwire/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1075,7 +1075,7 @@ func (s *Server) newConn(
// maxRepeatedErrorCount is the number of times an error can be received
// while reading from the network connection before the server decides to give
// up and abort the connection.
const maxRepeatedErrorCount = 1 << 15
const maxRepeatedErrorCount = 1 << 8
Copy link
Collaborator

@msbutler msbutler Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you added this commit to the backport, just to prevent merge conflicts, right?

Copy link
Collaborator

@msbutler msbutler Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like in the subsequent commit, the default is 1<<15, which i think makes sense.

Copy link
Collaborator Author

@rafiss rafiss Oct 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that was my thinking with this


// serveImpl continuously reads from the network connection and pushes execution
// instructions into a sql.StmtBuf, from where they'll be processed by a command
Expand Down