Skip to content

Conversation

michae2
Copy link
Collaborator

@michae2 michae2 commented Oct 17, 2025

Backport 1/2 commits from #155035.

/cc @cockroachdb/release


opt/props: only check histogram NumRange=0 in test builds

These assertions that the first histogram bucket has NumRange=0 are
useful for catching bugs, but a liability in production
environments. Even with malformed histograms, we should not be failing
query execution. Only check these assertions in test builds.

Informs: #154461

Release note (bug fix): Change assertions about histogram NumRange=0 to
only be checked in test builds.


Release justification: low-risk fix for a critical support issue.

These assertions that the first histogram bucket has NumRange=0 are
useful for catching bugs, but a liability in production
environments. Even with malformed histograms, we should not be failing
query execution. Only check these assertions in test builds.

Informs: cockroachdb#154461

Release note (bug fix): Change assertions about histogram NumRange=0 to
only be checked in test builds.
@michae2 michae2 requested review from a team and yuzefovich October 17, 2025 19:00
Copy link

blathers-crl bot commented Oct 17, 2025

Thanks for opening a backport.

Before merging, please confirm that the change does not break backwards compatibility and otherwise complies with the backport policy. Include a brief release justification in the PR description explaining why the backport is appropriate. All backports must be reviewed by the TL for the owning area. While the stricter LTS policy does not yet apply, please exercise judgment and consider gating non-critical changes behind a disabled-by-default feature flag when appropriate.

@blathers-crl blathers-crl bot added backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team labels Oct 17, 2025
Copy link

blathers-crl bot commented Oct 17, 2025

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@yuzefovich yuzefovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuzefovich reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @michae2)

@michae2 michae2 merged commit 6973f76 into cockroachdb:release-25.4 Oct 20, 2025
15 checks passed
@michae2 michae2 deleted the backport25.4-155035 branch October 20, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Label PR's that are backports to older release branches T-sql-queries SQL Queries Team target-release-25.4.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants