backup: introduce unified WriteBackupMetadata helper #155647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Epic: none Release note: none
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=95b789b1d594ac6b74f377aa7555d8d98d63240d&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
msbutler
changed the title
|
This change is |
msbutler
requested review from
jeffswenson and
kev-cao
and removed request for
a team and
jeffswenson
kev-cao
reviewed
Oct 17, 2025
This helper will be used by full, inc and compacted backups. This helper will make it much easier to support locality aware compacted backups. Epic: none Release note: none
Epic: none Release note: none
msbutler
force-pushed
the
butler-unify-backup-metadata-write-2
branch
from
18f12a1 to
c87fa68
Compare
|
TFTR! bors r=kev-cao |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper will be used by full, inc and compacted backups. This helper will
make it much easier to support locality aware compacted backups.
Epic: none
Release note: none