Conversation
242ab7f to
8ee0006
Compare
|
Tested this locally and it worked as expected |
8ee0006 to
f99ec07
Compare
|
No breaking changes detected. |
c389a70 to
b1e2713
Compare
a96edc4 to
fc74aa3
Compare
fc74aa3 to
de23fd1
Compare
de23fd1 to
67ffaf4
Compare
|
thanks for including the sample images. I noticed that the Changelog entries are extremely long. I think we'll want to experiment with the prompt we're using to build those. |
Please note this workflow does not generate any new changelog entries. This workflow simply takes the changelog entries from the unreleased section and puts them in the commit message and PR description for visibility (to recap what is going to be released). That is what you're seeing in the images I included. The long changelog entry you're referring to is a changelog entry for another workflow I added earlier. It's not LLM generated. The only thing the workflow in this PR is responsible for is updating the SDK version in the CHANGELOG and all other files that need the version number updated in preparation for the release. |
52e4efe to
23eaa26
Compare
yeah makes sense. I didn't think it was coming from this PR. It just looked long and agent generated. You hand crafted it though? |
I did use claude to write it. It's the changelog entry for this PR. I'was just trying to say it's not autogenerated by a workflow based on any prompt. I can update the relevant PR to make the entry shorter but it's a one off |
cf22100 to
26a06db
Compare
26a06db to
4b5eccc
Compare
|
@fantapop I've updated the reusable action to remove changelog entries from the commit message body. Why: Commit message lines should be at most 72 characters, but changelog entries don't follow this rule. It would be unnecessarily complex to convert the changelog entries to wrap at 72 characters for the commit message. Since the individual commits already describe the changes and the changelog entries are visible in the PR description, the simpler approach is to use a hardcoded message format. Here's the PR: cockroachdb/actions#27 |
f49c201 to
5ec108f
Compare
ah I see. makes sense. we are planning to generate the changelog entry from claude though right? We should consider asking it to keep it brief. |
5ec108f to
03ec431
Compare
fantapop
left a comment
There was a problem hiding this comment.
This is looking good to me. It seems like we could get away with logging to stdout for info lines and stderr for warn and error lines.
cd6bda8 to
c238887
Compare
Added GitHub Actions workflow that automatically creates release PRs when pending-deploy-* branches are merged to main. The workflow updates go.mod for major version changes, updates config.yaml with the new version, and regenerates the OpenAPI client to automatically update all generated files (README.md, docs/README.md, pkg/client/configuration.go, and other generated code). Co-Authored-By: roachdev-claude <roachdev-claude-bot@cockroachlabs.com>
c238887 to
a5a4706
Compare
Added GitHub Actions workflow that automatically creates release PRs when pending-deploy-* branches are merged to main. The workflow uses the reusable workflow from cockroachdb/actions and updates all version references across the SDK including CHANGELOG.md, go.mod, config files, and documentation.