Revealable text, both password masking and ellipsizing details #2383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
|
Member
There was a problem hiding this comment.
This makes the dots appear grayish instead of black (like the text). Is that intended?
Contributor
Author
There was a problem hiding this comment.
Yes, that's intentional. The dots are too big, and stand out too much if they are of identical color.
Contributor
Author
|
Included revealable.css in debug data. |
This manually cherry-picks: kubernetes-ui/object-describer#21 Closes cockpit-project#2383
stefwalter
force-pushed
the
kubernetes-revealable
branch
from
2b37041 to
8f3daa9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This manually cherry-picks:
kubernetes-ui/object-describer#21