job-runner: support JSON config#9198
Merged
Merged
Conversation
We're going to start generating dynamic configs and it's easier to do this with JSON than TOML.
Venefilyn
approved these changes
Jun 16, 2026
jelly
reviewed
Jun 16, 2026
| content = json.load(file) | ||
| else: | ||
| content = tomllib.load(file) | ||
| except (tomllib.TOMLDecodeError, json.JSONDecodeError) as exc: |
Member
There was a problem hiding this comment.
With standard lib sure but we could depend on tomli-w.
Member
There was a problem hiding this comment.
Unrelated to this PR though since this is just about JSON. But why not use tomllib? Was added in 3.11
Member
Author
There was a problem hiding this comment.
tomllib is readonly, isn't it?
mvollmer
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're going to start generating dynamic configs and it's easier to do this with JSON than TOML.