various fixes from fallout from task.py removal#9164
Merged
Conversation
Most callers who want the return value of this function are interested only in the number of the created pull request. Return that directly. The only other thing that anyone was using the data for was to get the SHA of the HEAD of the PR but we have that information locally since we just pushed it. It's also not going to be useful soon: we will start force-pushing which changes the sha. Callers that need that information can fetch it themselves from the local repository. Assisted-by: Claude Opus 4.6
PRs created with the `GITHUB_TOKEN` from the workflow run don't trigger workflow events due to GitHub's recursive-trigger protection. The old `task.pull()` worked around this by amending the commit and forcepushing via the deploy key (SSH). Let's do the same. Assisted-by: Claude Opus 4.6
We used to download the old image as the first thing that we do when creating a new version of it. We tried to move that download down until after we created the new image but it broke: we download by the image name and the symlink was already updated at that point, more or less guaranteeing that the download will fail. Move it back up to the top: it's pointless work in an edge case (the image is unchanged), but it *is* an edge case.
allisonkarlitskaya
force-pushed
the
bots-fixes
branch
from
733d4f7 to
8a4dfde
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.