Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces configuration to use the following pre commit hooks:
It is easy to have differing opinions about code style but it is desirable to agree on some baseline. Having a character limit makes code more readable. Inconsistent style can be unnecessarily distracting.
The enforcement in this PR makes several concessions.
Use
Pycharm can be configure to run pre-commit before committing (it seemed to pick up this configuration automatically).
Make sure you have the latest version of pre-commit installed (version 4.1.0).
To run the check:
pre-commit run --all-filesBlack will make style changes automatically. You can add
--in-placeas an argument for the doc-formatter in the pre-commit config file to allow it to make changes. The default behaviour is to show suggested diffs for changes. Use this with caution however as it does not understand large docstrings with code examples well and is prone to squash them together into something unintelligible.If everything's okay we get this nice output: