Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing slashes #39

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Allow trailing slashes #39

merged 1 commit into from
Jul 9, 2019

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented Jul 8, 2019

No description provided.

@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #39   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
=====================================
  Hits           29     29
Impacted Files Coverage Δ
giturlparse/parser.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a5377...73dec59. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 8, 2019

Codecov Report

Merging #39 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #39   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           2      2           
  Lines          29     29           
=====================================
  Hits           29     29
Impacted Files Coverage Δ
giturlparse/parser.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98a5377...73dec59. Read the comment docs.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 8, 2019

@retr0h , wrt "(No longer maintained)" , would you care to allow other people to help maintaining this. @sks444 , @virresh and/or myself from @coala would be able to help.

I had this packaged for openSUSE. https://software.opensuse.org/package/python3-git-url-parse

@retr0h
Copy link
Collaborator

retr0h commented Jul 9, 2019

@jayvdb I knew you would come back :) I removed issues because I couldn't maintain this code, and was unsuccessful in getting your interest in fixing issues when /cc'ing you guys.

@retr0h retr0h merged commit d3eac95 into coala:master Jul 9, 2019
@jayvdb
Copy link
Member Author

jayvdb commented Jul 10, 2019

I'm very sorry I missed your messages. I tend to work on priority queues where I am a maintainer. Anyway, offer stands. Happy to take a greater role. Ideal would be moving the repo under coala, so it uses our queues. But that is optional.

@retr0h
Copy link
Collaborator

retr0h commented Jul 10, 2019

I'm very sorry I missed your messages. I tend to work on priority queues where I am a maintainer. Anyway, offer stands. Happy to take a greater role. Ideal would be moving the repo under coala, so it uses our queues. But that is optional.

I'm happy to transfer it, let me know.

@jayvdb
Copy link
Member Author

jayvdb commented Jul 10, 2019

I've sent you an invite to join @coala , which I think you need to be able to do the transfer. After the transfer you can leave again if you want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants