Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Match Multiple paths. #37

Closed
wants to merge 1 commit into from
Closed

Bugfix: Match Multiple paths. #37

wants to merge 1 commit into from

Conversation

HaloGithub
Copy link

Since GitLab has Group and SubGroup concept, and repo can be under SubGroup, so the repo URL can be https://gitlab.example.com/group/sub-group/example.git.

@@ -260,6 +260,17 @@ def first_match_urls():
'name': 'Stouts.openvpn',
'owner': 'tterranigma',
},
'https://github.com/Group/Owner/Stouts.openvpn.git': {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test case shouldnt be github ; it should be gitlab

Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also commit message would be better noting this is a new feature, as it isnt a bug in existing supported functionality. GitLab has added features which havent yet been added here

@HaloGithub
Copy link
Author

Hi @jayvdb, thanks for your suggestion and I have create another one PR #40 of this instead.

@HaloGithub HaloGithub closed this Jul 10, 2019
@TonisPiip
Copy link

TonisPiip commented May 8, 2023

jayvdb Can we get some progress on this? Weird how this issue is just closed, but it's a pretty clear missed use-case for this software.

If clear changes are required, please list them I can can do them likely, but would like to know the MR would be accepted and released if effort is applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants