Support npm-style #ref suffix; fixes issue 16

[dankegel]

Also save one call to re.search().

[dankegel]

It's an open question whether the last commit should be included.

It's also an open question whether branch should default to None or to "master".

The code I'm writing that uses this now looks like

  parsedrepo = giturlparse.parse(repourl)
  name = parsedrepo.name
  # Don't know what giturlparse defaults will be for branch and href yet.
  # I want to write
  #  branch = parsedrepo.ref
  #  repourl = parsedrepo.href
  # but until those are nailed down, be more careful:
  branch = parsedrepo.ref if parsedrepo.ref else "master"
  repourl = repourl.split('#')[0]

[retr0h]

Why would we be parsing npm urls?

[retr0h]

Why would this ever be used? https://docs.npmjs.com/files/package.json#git-urls-as-dependencies? Thats an NPM url.

[dankegel]

That's just an example of one project that uses the convention. yarn uses it, too.

I've been using it in my scripts to configure buildbot, and I find it useful.

[dankegel]

That said, it's not that much code to do without this feature.

[retr0h]

Sure, but npm isnt a git url neither are yarn urls. I have not seen a git url having this format so I would have a hard time accepting a PR like this bc it's outside the scope of the project.

[dankegel]

I think it's a useful convention even outside of npm, but it's easy to implement as a tiny wrapper around git-url-parse, so closing.