Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.travis.yml: Check GITHUB_TOKEN before deploy #61

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

.travis.yml: Check GITHUB_TOKEN before deploy #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .ci/check_travis_deploy_vars.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash

set -ex

if [[ $TRAVIS_BRANCH == master && $TRAVIS_EVENT_TYPE == push &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"$TRAVIS_BRANCH" == "master" && "$TRAVIS_EVENT_TYPE" == "push" is the convention, I believe, so that words with spaces or special characters don't break the script.

! "$GITHUB_TOKEN" ]]; then
echo "Please set GITHUB_TOKEN in your Travis CI environment settings"
false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why false instead of exit 1?

fi
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,7 @@ jobs:
script: coala --non-interactive -V

before_install:
- .ci/check_travis_deploy_vars.sh
- npm config set spin false

before_script:
Expand Down