-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Users/Docker_Image.rst: Fix copyright violation #494
Conversation
Please use |
Users/Docker_Image.rst
Outdated
@@ -1,6 +1,8 @@ | |||
What is Docker? | |||
=============== | |||
|
|||
According to `opensource.com <https://opensource.com/resources/what-docker>`__: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm that reads bad as a first sentence. Rather I would make some kind of citation at the end^^
Also:
The layout needs to be very clear that it is an unmodified copy only, and no editing of the text is desirable.
Not sure that this intention gets to the reader here^^
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the requested changes
unack 684e22a |
Users/Docker_Image.rst
Outdated
not already running on the host computer. This gives a significant | ||
performance boost and reduces the size of the application. | ||
|
||
Source for this information is `opensource.com <https://opensource.com/resources/what-docker>`__. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe just Cited from ...
Commit message: Please add a tag ( Also add please a commit body describing why the text has changed (to make a full cite without any differences). |
unack a263ecc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The layout needs to be more explicit that it is a copy, and it needs to say it is copied under the terms of the CC-BY-SA-4
@jayvdb added that it is used under CC-BY-SA 4.0 along with the link. |
ab31c27
to
d7069e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It needs to be block quoted.
And the commit message is still not right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acashmkj : As other reviewers have already noted, you need to make the copied text(the one for which the license is applicable) a block-quote. You can do so by indenting the paragraph. Here’s some documentation for help
Also, looks like your commit message has and CC-BY-SA license.
in a line by itself, make that a part of the commit body please.
@gitmate-bot rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
ack ca85ea3 |
@gitmate-bot rebase |
and CC-BY-SA license. Added citation source and cited without any change and added reference to CC-BY-SA 4.0 license Closes coala#482
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
@gitmate-bot ff |
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
Automated fastforward with GitMate.io was successful! 🎉 |
Fixed copyright violation in Users/Docker_Image.rst by referencing the
source and added refernce to CC-BY-SA 4.0 license
Closes #482
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!