Import getorg data #81

sks444 · 2018-02-19T10:30:25Z

Closes #18

gitmate-bot · 2018-02-19T10:33:49Z

community/settings.py

+
+gh_key = 'Your_github_token'
+
+#https://developers.google.com/maps/documentation/javascript/get-api-key


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmp_u3roec1/community/settings.py +++ b/tmp/tmp_u3roec1/community/settings.py @@ -126,5 +126,5 @@ gh_key = 'Your_github_token' -#https://developers.google.com/maps/documentation/javascript/get-api-key +# https://developers.google.com/maps/documentation/javascript/get-api-key GEOPOSITION_GOOGLE_MAPS_API_KEY = 'YOUR_API_KEY'

gitmate-bot · 2018-02-19T10:33:50Z

community/settings.py

+
+gh_key = 'Your_github_token'
+
+#https://developers.google.com/maps/documentation/javascript/get-api-key


E265 block comment should start with '# '

Origin: PycodestyleBear (E265), Section: all.autopep8.

gitmate-bot · 2018-02-19T10:36:34Z

community/settings.py

+
+gh_key = 'Your_github_token'
+
+#https://developers.google.com/maps/documentation/javascript/get-api-key


The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpxjkkgmwn/community/settings.py +++ b/tmp/tmpxjkkgmwn/community/settings.py @@ -126,5 +126,5 @@ gh_key = 'Your_github_token' -#https://developers.google.com/maps/documentation/javascript/get-api-key +# https://developers.google.com/maps/documentation/javascript/get-api-key GEOPOSITION_GOOGLE_MAPS_API_KEY = 'YOUR_API_KEY'

gitmate-bot · 2018-02-19T10:36:35Z

community/settings.py

+
+gh_key = 'Your_github_token'
+
+#https://developers.google.com/maps/documentation/javascript/get-api-key


E265 block comment should start with '# '

Origin: PycodestyleBear (E265), Section: all.autopep8.

sks444 · 2018-02-19T10:54:24Z

@jayvdb , A PR for storing participant geolocation to data model. :)
And I am sorry, I have done some terrible mistakes. That's why I will be having two closed PR in closed PR section. I tried to correct the mistakes but it got more worse, I am sorry for that, It will not happen again.

sks444 · 2018-02-19T13:48:57Z

This PR uses django-geoposition for storing geolocations and getorg for fetching geolocation of participants for a organisation.

jayvdb · 2018-03-10T03:52:21Z

nice strategy. IMO we need a getorg data model, as it has lots of lovely data.

And then we need the geolocation data model to link to the data in the getorg data model.

Worth considering, ... the OpenHub data model will also give us similar user information, so that will also need to be integrated, and we now have the 'coala.io API' user data.

Eventually ... we need a single 'person' , with links to various datasets that we import about that person.

sks444 · 2018-03-10T04:40:14Z

IMO we need a getorg data model, as it has lots of lovely data.

Alright, I will try get some more data from their 👍

gitmate-bot · 2018-03-10T04:40:16Z

Sorry @sks444, you do not have the necessary permission levels to perform the action.

sks444 · 2018-03-10T04:42:27Z

Eventually ... we need a single 'person' , with links to various datasets that we import about that person.

Yeah, I was thinking of it too, we will work on that 👍

gitmate-bot · 2018-03-10T04:42:30Z

Sorry @sks444, you do not have the necessary permission levels to perform the action.

gitmate-bot · 2018-04-03T07:44:36Z

geolocation/management/commands/import_geolocation.py

+        Makes a GET request to the  API.
+        """
+        for key, value in org_location_dict.items():
+        	self.import_data(key, value)


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpcu_8idl1/geolocation/management/commands/import_geolocation.py +++ b/tmp/tmpcu_8idl1/geolocation/management/commands/import_geolocation.py @@ -37,4 +37,4 @@ Makes a GET request to the API. """ for key, value in org_location_dict.items(): - self.import_data(key, value) + self.import_data(key, value)

gitmate-bot · 2018-04-03T07:44:37Z

geolocation/models.py

+    position = GeopositionField()
+
+    def __str__(self):
+    	return self.name


Line contains following spacing inconsistencies:

Tabs used instead of spaces.

Origin: SpaceConsistencyBear, Section: all.whitespace.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpcu_8idl1/geolocation/models.py +++ b/tmp/tmpcu_8idl1/geolocation/models.py @@ -6,4 +6,4 @@ position = GeopositionField() def __str__(self): - return self.name + return self.name

gitmate-bot · 2018-04-03T07:44:38Z

geolocation/management/commands/import_geolocation.py

+from github import Github
+import getorg
+
+# Get an API key (for just querying, give it no write permissions) at https://github.com/settings/tokens


Line is longer than allowed. (104 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2018-04-03T07:44:39Z

geolocation/management/commands/import_geolocation.py

+                c.save()
+                print ("\nContributor, {}, has been saved.".format(c))
+        except Exception as ex:
+            print ("\n\nSomething went wrong saving this contributor: {}\n{}".format(name, str(ex)))


Line is longer than allowed. (100 > 80)

Origin: LineLengthBear, Section: all.linelength.

gitmate-bot · 2018-04-03T07:44:40Z

geolocation/models.py

+from django.db import models
+from geoposition.fields import GeopositionField
+
+class Participant(models.Model):


E302 expected 2 blank lines, found 1

Origin: PycodestyleBear (E302), Section: all.python.models.

gitmate-bot · 2018-04-03T07:44:41Z

geolocation/models.py

+    position = GeopositionField()
+
+    def __str__(self):
+    	return self.name


E101 indentation contains mixed spaces and tabs

Origin: PycodestyleBear (E101), Section: all.python.models.

gitmate-bot · 2018-04-03T07:44:42Z

geolocation/models.py

+    position = GeopositionField()
+
+    def __str__(self):
+    	return self.name


W191 indentation contains tabs

Origin: PycodestyleBear (W191), Section: all.python.models.

Closes #18

jayvdb

This should be done in webservices, where it can be more appropriately cached, and then data imported here.

jayvdb · 2018-08-11T12:13:54Z

Maybe this should be new repo , django-getorg ?

If you can create it, I can talk to the getorg ppls and ask them to transfer it to their org.
I am sure they will be happy with that. I know the main guy from @wikimedia .

gitmate-bot added process/pending review size/XS difficulty/medium labels Feb 19, 2018

gitmate-bot reviewed Feb 19, 2018

View reviewed changes

gitmate-bot added size/S and removed size/XS labels Feb 19, 2018

gitmate-bot assigned sks444 Apr 3, 2018

gitmate-bot reviewed Apr 3, 2018

View reviewed changes

sks444 changed the title ~~Add participants geolocation to data model~~ Import getorg data Apr 3, 2018

gitmate-bot reviewed Apr 3, 2018

View reviewed changes

gitmate-bot added size/M and removed size/S labels Apr 12, 2018

Import Getorg data

61aecb3

Closes #18

jayvdb requested changes May 8, 2018

View reviewed changes

jayvdb added the process/wip label May 8, 2018

jayvdb removed the process/pending review label May 8, 2018

gitmate-bot added the status/STALE label Jun 10, 2018

gitmate-bot removed the status/STALE label Aug 11, 2018

sks444 mentioned this pull request Mar 13, 2019

_projects: Add "Enhance Website Architecture" project to projects list coala/projects#719

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Import getorg data #81

Import getorg data #81

sks444 commented Feb 19, 2018

gitmate-bot Feb 19, 2018

gitmate-bot Feb 19, 2018

gitmate-bot Feb 19, 2018

gitmate-bot Feb 19, 2018

sks444 commented Feb 19, 2018 •

edited

Loading

sks444 commented Feb 19, 2018

jayvdb commented Mar 10, 2018

sks444 commented Mar 10, 2018

gitmate-bot commented Mar 10, 2018

sks444 commented Mar 10, 2018

gitmate-bot commented Mar 10, 2018

gitmate-bot Apr 3, 2018

gitmate-bot Apr 3, 2018

gitmate-bot Apr 3, 2018

gitmate-bot Apr 3, 2018

gitmate-bot Apr 3, 2018

gitmate-bot Apr 3, 2018

gitmate-bot Apr 3, 2018

jayvdb left a comment

jayvdb commented Aug 11, 2018


		gh_key = 'Your_github_token'

		#https://developers.google.com/maps/documentation/javascript/get-api-key

Import getorg data #81

Are you sure you want to change the base?

Import getorg data #81

Conversation

sks444 commented Feb 19, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sks444 commented Feb 19, 2018 • edited Loading

sks444 commented Feb 19, 2018

jayvdb commented Mar 10, 2018

sks444 commented Mar 10, 2018

gitmate-bot commented Mar 10, 2018

sks444 commented Mar 10, 2018

gitmate-bot commented Mar 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jayvdb left a comment

Choose a reason for hiding this comment

jayvdb commented Aug 11, 2018

sks444 commented Feb 19, 2018 •

edited

Loading