Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add participants geolocation to data model #80

Closed
wants to merge 0 commits into from
Closed

Add participants geolocation to data model #80

wants to merge 0 commits into from

Conversation

sks444
Copy link
Member

@sks444 sks444 commented Feb 19, 2018

Closes #18


gh_key = 'Your_github_token'

#https://developers.google.com/maps/documentation/javascript/get-api-key
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not comply to PEP8.

Origin: PEP8Bear, Section: all.autopep8.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpic6lc0sz/community/settings.py
+++ b/tmp/tmpic6lc0sz/community/settings.py
@@ -127,5 +127,5 @@
 
 gh_key = 'Your_github_token'
 
-#https://developers.google.com/maps/documentation/javascript/get-api-key
+# https://developers.google.com/maps/documentation/javascript/get-api-key
 GEOPOSITION_GOOGLE_MAPS_API_KEY = 'YOUR_API_KEY'


gh_key = 'Your_github_token'

#https://developers.google.com/maps/documentation/javascript/get-api-key
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E265 block comment should start with '# '

Origin: PycodestyleBear (E265), Section: all.autopep8.

@sks444 sks444 closed this Feb 19, 2018
@sks444 sks444 reopened this Feb 19, 2018
@sks444 sks444 closed this Feb 19, 2018
@sks444 sks444 deleted the geolocation branch February 19, 2018 09:52
@sks444 sks444 restored the geolocation branch February 19, 2018 09:53
@Makman2
Copy link
Member

Makman2 commented Feb 20, 2018

Please don't close PRs just because of gitmate issues. You can always fix them up in the same PR.

@sks444
Copy link
Member Author

sks444 commented Feb 20, 2018

@Makman2 , I am sorry :(
But, I didn't close these PRs for gitmate issues. I accidentally did something terrible, and when I tried to correct it, it got more worse. :( I am sorry it will not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants