.coafile: Ignore coala in generated GCI files #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
force-pushed
the
ignore-coala-in-generated-files
branch
from
b6f0160 to
890cafa
Compare
The GCI exported data contains 'coala', so it needs to be excluded from the relevant checks. Also ignore private/** and delete it regularly, as a preventative measure for accidental leaks. Related to coala#3
yukiisbored
reviewed
Dec 17, 2017
| @@ -7,6 +7,7 @@ mkdir private _site public | |||
| if [[ -n "$GCI_TOKEN" ]]; then | |||
| python manage.py fetch_gci_task_data private | |||
| python manage.py cleanse_gci_task_data private _site | |||
| rm -rf private/ | |||
There was a problem hiding this comment.
The private data collected on line 8 has been cleansed and pushed into _site , and is no longer needed. It is what is causing the coala errors. This is the first place to remove it.
yukiisbored
reviewed
Dec 17, 2017
| @@ -12,6 +12,7 @@ before_install: | |||
|
|
|||
| script: | |||
| - ./.ci/build.sh | |||
| - rm -rf private/ | |||
There was a problem hiding this comment.
and in case somehow the directory is still existing here, it should be removed. Extra careful.
|
ack 890cafa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GCI exported data contains 'coala',
so it needs to be excluded from the relevant checks.
Also ignore private/** and delete it regularly,
as a preventative measure for accidental leaks.
Related to #3