Create cache #49
Merged
Create cache #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gitmate-bot
reviewed
Dec 14, 2017
| input_dir = options.get('input_dir') | ||
| output_dir = options.get('output_dir') | ||
|
|
||
| yaml=YAML() |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmp7z8hoon4/gci/management/commands/cleanse_gci_task_data.py
+++ b/tmp/tmp7z8hoon4/gci/management/commands/cleanse_gci_task_data.py
@@ -25,7 +25,7 @@
input_dir = options.get('input_dir')
output_dir = options.get('output_dir')
- yaml=YAML()
+ yaml = YAML()
with open(os.path.join(input_dir, 'tasks.yaml'), 'r') as f:
tasks = yaml.load(f)
|
Comment on d236d19, file gci/management/commands/fetch_gci_task_data.py, line 34. The code does not comply to PEP8. Origin: PEP8Bear, Section: The issue can be fixed by applying the following patch: --- a/tmp/tmp7z8hoon4/gci/management/commands/fetch_gci_task_data.py
+++ b/tmp/tmp7z8hoon4/gci/management/commands/fetch_gci_task_data.py
@@ -31,7 +31,7 @@
tasks = OrderedDict(sorted(tasks.items(), key=lambda t: t[0]))
instances = OrderedDict(sorted(instances.items(), key=lambda t: t[0]))
- yaml=YAML()
+ yaml = YAML()
with open(os.path.join(output_dir, 'tasks.yaml'), 'w') as f:
yaml.dump(tasks, f) |
gitmate-bot
reviewed
Dec 14, 2017
| input_dir = options.get('input_dir') | ||
| output_dir = options.get('output_dir') | ||
|
|
||
| yaml=YAML() |
There was a problem hiding this comment.
E225 missing whitespace around operator
Origin: PycodestyleBear (E225), Section: all.autopep8.
|
Comment on d236d19, file gci/management/commands/fetch_gci_task_data.py, line 34. E225 missing whitespace around operator Origin: PycodestyleBear (E225), Section: |
jayvdb
force-pushed
the
create_cache
branch
3 times, most recently
from
c06915d to
7501c4f
Compare
Separates the fetch operation from the load operation, allowing the build on forks to use a cached dataset. Related to coala#3
Before the Google Code-in data can be stored in the repository, the data of students who are just starting needs to be removed, the status types need to be simplified to reduce side channels, the unpublished tasks need to be removed, and task mentor list needs to be removed. Related to coala#3
jayvdb
force-pushed
the
create_cache
branch
5 times, most recently
from
17a2301 to
731aa97
Compare
The cleansed data can be fetched from the production website if the origin remote is set to be production repository, as it is on pull requests for Travis CI. This does not yet allow branch builds on forks, as their origin will not be the production repository. Related to coala#3
|
ack 9f1d548 |
|
ack 940cce5 |
|
ack 731aa97 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the fix for #3