Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.gitignore: Ignore editor and other temp files #47

Closed
wants to merge 1 commit into from

Conversation

Monal5031
Copy link
Member

Update .gitignore to ignore .idea/
dir .DS_Store and static/acitivity-data.json

Closes #46

@Monal5031 Monal5031 changed the title .gitignore: Ignore .idea/ .DS_Store static/activity-data.jso .gitignore: Ignore .idea/ .DS_Store static/activity-data.json Dec 14, 2017
Copy link
Member

@prnvdixit prnvdixit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa... that is quite a long shortlog 😉
Just make it .gitignore: Add editor and other temp files and add the names of relevant files in description 😄

@Monal5031
Copy link
Member Author

Old habit to write descriptive things 😅 Fixed it though @prnvdixit

@Monal5031 Monal5031 changed the title .gitignore: Ignore .idea/ .DS_Store static/activity-data.json .gitignore: Ignore editor and other temp files Dec 14, 2017
@@ -103,3 +103,7 @@ ENV/
_site/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be the last set, as they are specific to this repository.

.idea and other common problems should appear earlier.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. 😄

@jayvdb
Copy link
Member

jayvdb commented Dec 14, 2017

ack c204dac

Update .gitignore to ignore .idea/
dir .DS_Store and static/acitivity-data.json

Closes coala#46
@jayvdb
Copy link
Member

jayvdb commented Dec 15, 2017

unack 2e627b6

@jayvdb
Copy link
Member

jayvdb commented Dec 15, 2017

This wont be necessary after my other patches

@Monal5031
Copy link
Member Author

Monal5031 commented Dec 15, 2017

@jayvdb The .idea dir and .DS_Store file 😕 that aren't included in your PRs

@jayvdb
Copy link
Member

jayvdb commented Dec 16, 2017

@Monal5031 , common gitignore entries can be done using moban. Setting that up is my next project after getting the GCI app here working.

@Monal5031
Copy link
Member Author

Closing this as its not needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants