-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.coafile: Add commit section #106
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@@ -16,6 +16,10 @@ before_install: | |||
script: | |||
- ./.ci/build.sh | |||
- rm -rf private/ | |||
- > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
On second thought, not a bad idea to add this comment here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be better.
@gitmate-bot rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
@gitmate-bot rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
eww.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change and this is good to go.
@@ -16,6 +16,10 @@ before_install: | |||
script: | |||
- ./.ci/build.sh | |||
- rm -rf private/ | |||
- > |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that would be better.
ping @anctartica |
Travis tests have failedHey @anctartica, 2nd Buildcoala --non-interactive -V
|
what the...!? It happened again. I've raised coala/coala#5479 about this. |
@gitmate-bot rebase |
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
Automated rebase with GitMate.io was successful! 🎉 |
Travis tests have failedHey @anctartica, 1st Buildcoala --non-interactive -V
|
Travis tests have failedHey @anctartica, 2nd Buildcoala --non-interactive -V
|
@anctartica, can you please add When I run this on my fork, there are no .bak, and the build is green. I have already cleared the cache in Travis for that PR, and re-run it, and the .bak still appears in https://travis-ci.org/coala/community/jobs/391294225 Interestingly there is now also another error in the log for this PR.
|
Travis tests have failedHey @anctartica, 2nd Buildcoala --non-interactive -V
|
@anctartica , ohh .. so your PR does have a Why it is only being picked up by your PR is still a bit of a mystery. |
@anctartica , can you remove the .bak , and see if that changes anything? |
Travis tests have failedHey @anctartica, 2nd Build./.ci/build.sh
|
This previous discussion explains why the |
What is the error, so I dont have to load the travis logs? |
The build script is failing with this error
|
@saksham189 Can you re-base and try to re-build the changes? Might it get resolved. |
Travis tests have failedHey @saksham189, TravisBuddy Request Identifier: ab73a8d0-3b5a-11e9-812b-253bd79ad219 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Closes #97