Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

D.yaml: Fix typo in line 10 "delimiters". #87

Closed
wants to merge 1 commit into from
Closed

D.yaml: Fix typo in line 10 "delimiters". #87

wants to merge 1 commit into from

Conversation

CleverFool77
Copy link
Member

@CleverFool77 CleverFool77 commented Dec 4, 2018 •
edited
Loading

Fixes: #69

I haven't received my Coala organisation invite yet. But I wanted to get started with contributing in Coala, So I made this Pull Request.

utkarsh2102
utkarsh2102 reviewed Dec 5, 2018
View reviewed changes
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
Please don't open PRs unless you've been assigned yet.
Get it assigned first and then make a PR.

jayvdb
jayvdb requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your commit message to comply with https://coala.io/commit

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Comment on 7613074, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

@CleverFool77
Copy link
Member Author

@jayvdb I didn't edit that file which shows (82>80) characters . Also that line is a url link with less chances of reducing two characters.

@naveentvelu
Copy link
Contributor

@CleverFool77 You can refer to either Javascript.yaml or verilog.yaml where the grammar_file is written in two lines.
This might help. :)

jayvdb
jayvdb requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix your commit message to comply with https://coala.io/commit . e.g. remove the : in the last line, but also recheck everything else about your commit message.

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Comment on 44e054d, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

@CleverFool77
Copy link
Member Author

CleverFool77 commented Dec 5, 2018 •
edited
Loading

The commit fixes the line length in VisualBasic.yaml and typo in D.yaml.

@CleverFool77 CleverFool77 force-pushed the issue_69 branch 2 times, most recently from 929e563 to 3543911 Compare December 5, 2018 15:13
@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

@gitmate-bot rebase

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Automated rebase with GitMate.io was successful! 🎉

jayvdb
jayvdb requested changes Dec 5, 2018
View reviewed changes
Copy link
Member

@jayvdb jayvdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not compliant with https://coala.io/commit

@CleverFool77
D.yaml: Fix typo in line 10 "delimiters"
405ff9e 
This fixes typo in and changes
it from delimters --> delimiters
Also It fixes line-length
of "grammar-file" in VisualBasic.yaml

Fixes coala#69
@CleverFool77
Copy link
Member Author

I'll open a new pr and closing this pr for now.

@utkarsh2102
Copy link
Member

@CleverFool77, you should never close PRs.
Work on this one. You would get to learn a lot.
Opening another PR is not the solution.

@CleverFool77
Copy link
Member Author

@utkarsh2102 While comparing for the merge conflict, I got to know that this issue has already been resolved. Since the issue has already been resolved, it's good to close this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarsh2102 utkarsh2102 utkarsh2102 left review comments

@jayvdb jayvdb jayvdb requested changes

Assignees
No one assigned
Labels
difficulty/newcomer process/pending review size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CleverFool77 @jayvdb @naveentvelu @utkarsh2102