Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove comment inconsistencies #80

Merged
merged 1 commit into from
Dec 5, 2018
Merged

Remove comment inconsistencies #80

merged 1 commit into from
Dec 5, 2018

Conversation

tanmaysachan
Copy link
Contributor

Fixes #68

li-boxuan
li-boxuan requested changes Dec 3, 2018
View reviewed changes
Copy link
Member

@li-boxuan li-boxuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Closes instead of Fixes in your commit messages.
Your commit message is not in the correct format (hint: one space line is missing)

You have 10 commits which are doing the same thing and changes are small. Use one commit instead.

@tanmaysachan
Copy link
Contributor Author

@li-boxuan updated commits.

Man-Jain
Man-Jain suggested changes Dec 4, 2018
View reviewed changes
Copy link
Member

@Man-Jain Man-Jain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 2 other files which have these inconsistencies like
https://github.com/coala/coAST/blob/master/data/Language/x86.yaml
https://github.com/coala/coAST/blob/master/data/Language/JSON.yaml
Please fix these too

Also the commit head could be
Language: Fix comment inconsistencies

It would also be nice if you add a little description for the commit.

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

@gitmate-bot rebase

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@tanmaysachan @gitmate-bot
Language: Fix comment inconsistencies
78e658e 
Remove trailing colons and fix typos

Closes coala#68
@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Automated rebase with GitMate.io was successful! 🎉

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

ack 78e658e

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

@gitmate-bot ff

@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@jayvdb jayvdb merged commit 78e658e into coala:master Dec 5, 2018
@jayvdb
Copy link
Member

jayvdb commented Dec 5, 2018

Automated fastforward with GitMate.io was successful! 🎉

@tanmaysachan tanmaysachan deleted the Issue68 branch April 21, 2019 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@li-boxuan li-boxuan li-boxuan requested changes

@Man-Jain Man-Jain Man-Jain requested changes

@jayvdb jayvdb jayvdb approved these changes

Assignees

@tanmaysachan tanmaysachan

Labels
difficulty/newcomer process/pending review size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tanmaysachan @jayvdb @Man-Jain @li-boxuan