Language.html.jinja2: Remove hyperlink if None #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayvdb
reviewed
Dec 1, 2018
templates/Language.html.jinja2
Outdated
| <a href = {{ language.grammar_file }}> | ||
| {{ m.show_grammar(language.grammar_file) }} | ||
| </a> | ||
| {% else %} | ||
| {{ m.show_grammar(language.grammar_file) }} | ||
| {% endif %} |
There was a problem hiding this comment.
Unlabeled control end tag
Origin: Jinja2Bear, Section: jinja2.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpo67x_gqp/templates/Language.html.jinja2
+++ b/tmp/tmpo67x_gqp/templates/Language.html.jinja2
@@ -20,7 +20,7 @@
</a>
{% else %}
{{ m.show_grammar(language.grammar_file) }}
- {% endif %}
+ {% endif %}{# if language.grammar_file #}
</td>
</tr>
<tr>
rajgoesout
force-pushed
the
hyperlinkfix
branch
from
db5bb8b to
4cb511e
Compare
|
ack 4cb511e |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #70