.coafile: Check yaml files and the templates #39

RazvanMitrica · 2018-11-05T12:19:05Z

This entrypoint adds a .coafile for .yaml
and .jinja2 files.

Closes #33

jayvdb · 2018-11-05T12:22:25Z

Comment on c7a7ee4, file templates/Language.html.jinja2, line 17.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/Language.html.jinja2
+++ b/tmp/tmpo9b7vard/templates/Language.html.jinja2
@@ -14,7 +14,7 @@
     <tr>
       <th>Grammar File</th>
       <td>
-        <a href = {{language.grammar_file}}>
+        <a href = {{ language.grammar_file }}>
           {{ m.show_grammar(language.grammar_file) }}
         </a>  
       </td>

jayvdb · 2018-11-05T12:22:26Z

Comment on c7a7ee4, file templates/macros.jinja2, line 6.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -3,7 +3,7 @@
 {{ language.full_name }}
 {% else %}
 {{ language.identifier }}
-{% endif %}
+{% endif %}{# if language.full_name #}
 {% endmacro %}
 
 {% macro show_grammar(grammar_file) %}

jayvdb · 2018-11-05T12:22:27Z

Comment on c7a7ee4, file templates/macros.jinja2, line 10.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -7,7 +7,7 @@
 {% endmacro %}
 
 {% macro show_grammar(grammar_file) %}
-  {{grammar_file}}
+  {{ grammar_file }}
 {% endmacro %}
 
 {% macro show_list(list, separator=',') %}

jayvdb · 2018-11-05T12:22:28Z

Comment on c7a7ee4, file templates/macros.jinja2, line 15.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -12,7 +12,7 @@
 
 {% macro show_list(list, separator=',') %}
   {% for item in list %}
-    {{ item.pk | escape }}{% if not loop.last %}{{separator}} {% endif %}
+    {{ item.pk | escape }}{% if not loop.last %}{{ separator }} {% endif %}
   {% endfor %}
 {% endmacro %}

jayvdb · 2018-11-05T12:22:29Z

Comment on c7a7ee4, file templates/macros.jinja2, line 16.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -13,7 +13,7 @@
 {% macro show_list(list, separator=',') %}
   {% for item in list %}
     {{ item.pk | escape }}{% if not loop.last %}{{separator}} {% endif %}
-  {% endfor %}
+  {% endfor %}{# for item in list #}
 {% endmacro %}
 
 {% macro show_delimiter_list(delimiters, type) %}

jayvdb · 2018-11-05T12:22:30Z

Comment on c7a7ee4, file templates/macros.jinja2, line 28.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -25,7 +25,7 @@
         <tt>{{ item.end | escape }}</tt>
       {% else %}
         (EOL)
-      {% endif %}
+      {% endif %}{# if item.end #}
     </li>
     {% endif %}
   {% endfor %}

jayvdb · 2018-11-05T12:22:31Z

Comment on c7a7ee4, file templates/macros.jinja2, line 30.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -27,7 +27,7 @@
         (EOL)
       {% endif %}
     </li>
-    {% endif %}
+    {% endif %}{# if item.type == type #}
   {% endfor %}
 </ul>
 {% endmacro %}

jayvdb · 2018-11-05T12:22:32Z

Comment on c7a7ee4, file templates/macros.jinja2, line 31.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/macros.jinja2
+++ b/tmp/tmpo9b7vard/templates/macros.jinja2
@@ -28,6 +28,6 @@
       {% endif %}
     </li>
     {% endif %}
-  {% endfor %}
+  {% endfor %}{# for item in delimiters #}
 </ul>
 {% endmacro %}

jayvdb · 2018-11-05T12:22:33Z

Comment on c7a7ee4, file templates/home.html.jinja2, line 16.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpo9b7vard/templates/home.html.jinja2
+++ b/tmp/tmpo9b7vard/templates/home.html.jinja2
@@ -13,7 +13,7 @@
   <ul class="thin-row-medium" id="languages-list">
   {% for language in languages %}
     <li><a href="{% url 'languages', language %}">{{ m.language_name(language) }}</a>
-  {% endfor %}
+  {% endfor %}{# for language in languages #}
   </ul>
 </body>
 </html>

jayvdb · 2018-11-05T12:36:50Z

Comment on da8c4cb, file templates/home.html.jinja2, line 16.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/home.html.jinja2
+++ b/tmp/tmplz2jz9lw/templates/home.html.jinja2
@@ -13,7 +13,7 @@
   <ul class="thin-row-medium" id="languages-list">
   {% for language in languages %}
     <li><a href="{% url 'languages', language %}">{{ m.language_name(language) }}</a>
-  {% endfor %}
+  {% endfor %}{# for language in languages #}
   </ul>
 </body>
 </html>

jayvdb · 2018-11-05T12:36:51Z

Comment on da8c4cb, file templates/Language.html.jinja2, line 17.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/Language.html.jinja2
+++ b/tmp/tmplz2jz9lw/templates/Language.html.jinja2
@@ -14,7 +14,7 @@
     <tr>
       <th>Grammar File</th>
       <td>
-        <a href = {{language.grammar_file}}>
+        <a href = {{ language.grammar_file }}>
           {{ m.show_grammar(language.grammar_file) }}
         </a>  
       </td>

jayvdb · 2018-11-05T12:36:52Z

Comment on da8c4cb, file templates/macros.jinja2, line 6.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -3,7 +3,7 @@
 {{ language.full_name }}
 {% else %}
 {{ language.identifier }}
-{% endif %}
+{% endif %}{# if language.full_name #}
 {% endmacro %}
 
 {% macro show_grammar(grammar_file) %}

jayvdb · 2018-11-05T12:36:53Z

Comment on da8c4cb, file templates/macros.jinja2, line 10.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -7,7 +7,7 @@
 {% endmacro %}
 
 {% macro show_grammar(grammar_file) %}
-  {{grammar_file}}
+  {{ grammar_file }}
 {% endmacro %}
 
 {% macro show_list(list, separator=',') %}

jayvdb · 2018-11-05T12:36:54Z

Comment on da8c4cb, file templates/macros.jinja2, line 15.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -12,7 +12,7 @@
 
 {% macro show_list(list, separator=',') %}
   {% for item in list %}
-    {{ item.pk | escape }}{% if not loop.last %}{{separator}} {% endif %}
+    {{ item.pk | escape }}{% if not loop.last %}{{ separator }} {% endif %}
   {% endfor %}
 {% endmacro %}

jayvdb · 2018-11-05T12:36:55Z

Comment on da8c4cb, file templates/macros.jinja2, line 16.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -13,7 +13,7 @@
 {% macro show_list(list, separator=',') %}
   {% for item in list %}
     {{ item.pk | escape }}{% if not loop.last %}{{separator}} {% endif %}
-  {% endfor %}
+  {% endfor %}{# for item in list #}
 {% endmacro %}
 
 {% macro show_delimiter_list(delimiters, type) %}

jayvdb · 2018-11-05T12:36:56Z

Comment on da8c4cb, file templates/macros.jinja2, line 28.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -25,7 +25,7 @@
         <tt>{{ item.end | escape }}</tt>
       {% else %}
         (EOL)
-      {% endif %}
+      {% endif %}{# if item.end #}
     </li>
     {% endif %}
   {% endfor %}

jayvdb · 2018-11-05T12:36:57Z

Comment on da8c4cb, file templates/macros.jinja2, line 30.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -27,7 +27,7 @@
         (EOL)
       {% endif %}
     </li>
-    {% endif %}
+    {% endif %}{# if item.type == type #}
   {% endfor %}
 </ul>
 {% endmacro %}

jayvdb · 2018-11-05T12:36:57Z

Comment on da8c4cb, file templates/macros.jinja2, line 31.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmplz2jz9lw/templates/macros.jinja2
+++ b/tmp/tmplz2jz9lw/templates/macros.jinja2
@@ -28,6 +28,6 @@
       {% endif %}
     </li>
     {% endif %}
-  {% endfor %}
+  {% endfor %}{# for item in delimiters #}
 </ul>
 {% endmacro %}

li-boxuan

CI is showing you a lot of errors, which is expected. 😉
Since you add rules in .coafile, CI is more powerful and it is able to detect errors using the bears you introduced. You need to fix those errors.

jayvdb · 2018-11-05T16:07:49Z

Comment on 3eb6313, file templates/Language.html.jinja2, line 17.

Variable blocks should be spaced with 1 spaces on each side.

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/Language.html.jinja2
+++ b/tmp/tmpn_oayuko/templates/Language.html.jinja2
@@ -14,7 +14,7 @@
     <tr>
       <th>Grammar File</th>
       <td>
-        <a href = {{language.grammar_file}}>
+        <a href = {{ language.grammar_file }}>
           {{ m.show_grammar(language.grammar_file) }}
         </a>  
       </td>

jayvdb · 2018-11-05T16:07:50Z

Comment on 3eb6313, file templates/macros.jinja2, line 6.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/macros.jinja2
+++ b/tmp/tmpn_oayuko/templates/macros.jinja2
@@ -3,7 +3,7 @@
 {{ language.full_name }}
 {% else %}
 {{ language.identifier }}
-{% endif %}
+{% endif %}{# if language.full_name #}
 {% endmacro %}
 
 {% macro show_grammar(grammar_file) %}

jayvdb · 2018-11-05T16:07:55Z

Comment on 3eb6313, file templates/macros.jinja2, line 16.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/macros.jinja2
+++ b/tmp/tmpn_oayuko/templates/macros.jinja2
@@ -13,7 +13,7 @@
 {% macro show_list(list, separator=',') %}
   {% for item in list %}
     {{ item.pk | escape }}{% if not loop.last %}{{separator}} {% endif %}
-  {% endfor %}
+  {% endfor %}{# for item in list #}
 {% endmacro %}
 
 {% macro show_delimiter_list(delimiters, type) %}

jayvdb · 2018-11-05T16:07:56Z

Comment on 3eb6313, file templates/macros.jinja2, line 28.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/macros.jinja2
+++ b/tmp/tmpn_oayuko/templates/macros.jinja2
@@ -25,7 +25,7 @@
         <tt>{{ item.end | escape }}</tt>
       {% else %}
         (EOL)
-      {% endif %}
+      {% endif %}{# if item.end #}
     </li>
     {% endif %}
   {% endfor %}

jayvdb · 2018-11-05T16:07:58Z

Comment on 3eb6313, file templates/macros.jinja2, line 30.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/macros.jinja2
+++ b/tmp/tmpn_oayuko/templates/macros.jinja2
@@ -27,7 +27,7 @@
         (EOL)
       {% endif %}
     </li>
-    {% endif %}
+    {% endif %}{# if item.type == type #}
   {% endfor %}
 </ul>
 {% endmacro %}

jayvdb · 2018-11-05T16:08:00Z

Comment on 3eb6313, file templates/macros.jinja2, line 31.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/macros.jinja2
+++ b/tmp/tmpn_oayuko/templates/macros.jinja2
@@ -28,6 +28,6 @@
       {% endif %}
     </li>
     {% endif %}
-  {% endfor %}
+  {% endfor %}{# for item in delimiters #}
 </ul>
 {% endmacro %}

jayvdb · 2018-11-05T16:08:02Z

Comment on 3eb6313, file templates/home.html.jinja2, line 16.

Unlabeled control end tag

Origin: Jinja2Bear, Section: jinja2.

The issue can be fixed by applying the following patch:

--- a/tmp/tmpn_oayuko/templates/home.html.jinja2
+++ b/tmp/tmpn_oayuko/templates/home.html.jinja2
@@ -13,7 +13,7 @@
   <ul class="thin-row-medium" id="languages-list">
   {% for language in languages %}
     <li><a href="{% url 'languages', language %}">{{ m.language_name(language) }}</a>
-  {% endfor %}
+  {% endfor %}{# for language in languages #}
   </ul>
 </body>
 </html>

views/languages.yaml

data/Language/TinyBasic.yaml

data/Language/JavaScript.yaml

data/Language/Python.yaml

data/Language/CSharp.yaml

jayvdb · 2018-11-06T02:13:18Z

.coafile

@@ -0,0 +1,16 @@
+[Default]


an empty Default is useless, and Default is deprecated anyway ... just remove

jayvdb · 2018-11-06T02:13:35Z

.coafile

+[Default]
+
+[autopep8]
+bears = PEP8Bear, PycodestyleBear


these are python bears, and there is no python files in this repo

jayvdb · 2018-11-06T02:14:04Z

.coafile

+
+[jinja2]
+bears = Jinja2Bear
+files = **.jinja2, **.jj2


there are no .jj2 files in this repo

I saw there were jj2 files on other repos and I thought that those kind of files could be included here in the future as well.

jayvdb · 2018-11-06T02:14:25Z

.coafile

+
+[yaml]
+bears = YAMLLintBear
+files = *.yml, **/*.yaml


**.yaml does the same thing

jayvdb · 2018-11-06T02:18:10Z

data/Language/TinyBasic.yaml

@@ -1,7 +1,8 @@
 identifier: TinyBasic
 full_name: TinyBasic
 wikidata: Q586622
-grammar_file: https://github.com/antlr/grammars-v4/tree/master/tinybasic/tinybasic.g4
+grammar_file: https://github.com/antlr/grammars-v4/tree/master/tinybasic
+              /tinybasic.g4


in other cases you leave the / on the previous line. here it is different. please be consistent.

This entrypoint adds a .coafile for .yaml and .jinja2 files. Closes coala#33

jayvdb · 2018-11-07T02:42:58Z

ack 923609d

jayvdb · 2018-11-07T02:43:10Z

@gitmate-bot ff

jayvdb · 2018-11-07T02:43:12Z

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

jayvdb · 2018-11-07T02:45:20Z

Automated fastforward with GitMate.io was successful! 🎉

jayvdb added process/pending review size/XS difficulty/low importance/high labels Nov 5, 2018

jayvdb assigned RazvanMitrica Nov 5, 2018

RazvanMitrica force-pushed the issue33 branch from c7a7ee4 to da8c4cb Compare November 5, 2018 12:32

RazvanMitrica force-pushed the issue33 branch from da8c4cb to 3eb6313 Compare November 5, 2018 16:06

li-boxuan requested changes Nov 5, 2018

View reviewed changes

li-boxuan added process/wip and removed process/pending review labels Nov 5, 2018

RazvanMitrica force-pushed the issue33 branch from 3eb6313 to be07671 Compare November 5, 2018 16:37

jayvdb added process/pending review size/M and removed process/wip size/XS labels Nov 5, 2018

jayvdb reviewed Nov 5, 2018

View reviewed changes

views/languages.yaml Show resolved Hide resolved

jayvdb reviewed Nov 5, 2018

View reviewed changes

data/Language/TinyBasic.yaml Show resolved Hide resolved

jayvdb reviewed Nov 5, 2018

View reviewed changes

data/Language/JavaScript.yaml Show resolved Hide resolved

jayvdb reviewed Nov 5, 2018

View reviewed changes

data/Language/Python.yaml Show resolved Hide resolved

jayvdb reviewed Nov 5, 2018

View reviewed changes

data/Language/CSharp.yaml Show resolved Hide resolved

RazvanMitrica force-pushed the issue33 branch from be07671 to 313a5f8 Compare November 5, 2018 17:47

jayvdb requested changes Nov 6, 2018

View reviewed changes

jayvdb added process/wip and removed process/pending review labels Nov 6, 2018

.coafile: Check yaml files and templates

923609d

This entrypoint adds a .coafile for .yaml and .jinja2 files. Closes coala#33

RazvanMitrica force-pushed the issue33 branch from 313a5f8 to 923609d Compare November 6, 2018 07:43

jayvdb added process/pending review and removed process/wip labels Nov 6, 2018

jayvdb approved these changes Nov 7, 2018

View reviewed changes

jayvdb merged commit 923609d into coala:master Nov 7, 2018

RazvanMitrica deleted the issue33 branch November 7, 2018 09:20

.coafile: Check yaml files and the templates #39

.coafile: Check yaml files and the templates #39

Conversation

RazvanMitrica commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

li-boxuan left a comment

Choose a reason for hiding this comment

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb commented Nov 5, 2018

jayvdb Nov 6, 2018

Choose a reason for hiding this comment

jayvdb Nov 6, 2018

Choose a reason for hiding this comment

jayvdb Nov 6, 2018

Choose a reason for hiding this comment

RazvanMitrica Nov 6, 2018

Choose a reason for hiding this comment

jayvdb Nov 6, 2018

Choose a reason for hiding this comment

jayvdb Nov 6, 2018

Choose a reason for hiding this comment

jayvdb commented Nov 7, 2018

jayvdb commented Nov 7, 2018

jayvdb commented Nov 7, 2018

jayvdb commented Nov 7, 2018