Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Grammar Files Property to webpage #29

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Added Grammar Files Property to webpage #29

merged 1 commit into from
Nov 3, 2018

Conversation

shakeelsamsu
Copy link
Contributor

@shakeelsamsu shakeelsamsu commented Nov 3, 2018 •
edited
Loading

macros.jinja2: Added macro for show_grammar
Language.html.jinja2: Added Grammar Files and Datatypes properties
Added grammar_file attribute to multiple language definitions

Related to #6

utkarsh2102
utkarsh2102 suggested changes Nov 3, 2018
View reviewed changes
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,
I think the grammar_file links need to be edited.
It is not redirecting to the file as it should.
For instance, the CPP link is directing here, whereas, it should redirect here.
You'd need to edit all the links once again.

jayvdb
jayvdb requested changes Nov 3, 2018
View reviewed changes
templates/Language.html.jinja2 Outdated Show resolved Hide resolved
utkarsh2102
utkarsh2102 approved these changes Nov 3, 2018
View reviewed changes
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jayvdb
Copy link
Member

jayvdb commented Nov 3, 2018

ack ccc5c78

@shakeelsamsu @jayvdb
Added Grammar Files property to webpage
ccc5c78 
Also populate `grammar_file` attribute for many languages.
@jayvdb
Copy link
Member

jayvdb commented Nov 3, 2018

@gitmate-bot ff

@jayvdb
Copy link
Member

jayvdb commented Nov 3, 2018

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@jayvdb jayvdb merged commit ccc5c78 into coala:master Nov 3, 2018
@jayvdb
Copy link
Member

jayvdb commented Nov 3, 2018

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jayvdb jayvdb jayvdb requested changes

@utkarsh2102 utkarsh2102 utkarsh2102 approved these changes

Assignees
No one assigned
Labels
process/approved size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shakeelsamsu @jayvdb @utkarsh2102