JSON.yaml: Add JSON definition #10
Conversation
data/Language/JSON.yaml
Outdated
| # Block delimiter: | ||
| - curly_braces | ||
| - square_braces | ||
| keywords: [] |
There was a problem hiding this comment.
You can remove this line as there are no keywords.
There was a problem hiding this comment.
I was unsure about what to do with that field, I'll remove it now
data/Language/JSON.yaml
Outdated
| - json | ||
| line_continuation: '' | ||
| delimiters: | ||
| # From coala JSON language definition |
data/Language/JSON.yaml
Outdated
| line_continuation: '' | ||
| delimiters: | ||
| # From coala JSON language definition | ||
| # JSON don't have any comments |
data/Language/JSON.yaml
Outdated
| # From coala JSON language definition | ||
| # JSON don't have any comments | ||
| # String delimiter: | ||
| - double_quote |
There was a problem hiding this comment.
JSON string have an escape character. Choose a more specific delimiter
There was a problem hiding this comment.
Oh, that's right. I was a bit confused by what delimiter to use, but I'll check them
There was a problem hiding this comment.
Is double_quote_slash_escape okay? I'm not sure about the difference between it and double_quote
There was a problem hiding this comment.
Yup, JSON uses backslash escaping.
data/Language/JSON.yaml
Outdated
| - json | ||
| aliases: | ||
| - json | ||
| line_continuation: '' |
There was a problem hiding this comment.
What does this mean?
Does JSON have a line continuation token?
If not, remove this property.
There was a problem hiding this comment.
Alright, so we just drop the properties if it's not used? At first I thought some property needs to be present, so I just kind of kept it there... I'll remember that next time, though!
git add .
Outdated
| @@ -0,0 +1,14 @@ | |||
| identifier: JSON | |||
There was a problem hiding this comment.
This file is created by mistake. Remove it 😃
There was a problem hiding this comment.
uh oh. I'm sorry, I'll remove it now!
There was a problem hiding this comment.
Looks good to me. One last thing. Please squash your commits into one. You can follow this guide https://api.coala.io/en/latest/Developers/Git_Basics.html#squashing-your-commits Please feel free to ask if you face any problem.
|
ack d0771c6 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
No description provided.