Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grammar file produces a hyperlink even when no value is given to it in the Language files #70

Closed
Naveenaidu opened this issue Nov 29, 2018 · 1 comment

Comments

@Naveenaidu
Copy link
Member

Naveenaidu commented Nov 29, 2018

Grammer file produces a hyperlink to the respective grammar files when we provide the entry to it in the language file.

Example:- C.yaml
grammar_file: https://github.com/antlr/grammars-v4/blob/master/c/C.g4

After the site is deployed, the results are rendered as: https://coast.netlify.com/c/
As you see here a hyperlink is produced for the grammar file.

But

When the grammar file field is empty or not mentioned in the language file such as Bash.yaml or Swift.yaml where the grammar file is not present.

When these files get rendered, they display the text None which hyperlinks to a page which do not exist.

Grammar File None

This needs to be fixed. Instead of showing None with a hyperlink. It should only show None without any hyperlinks.

label: difficulty/low

@rajgoesout
Copy link
Member

Can I work on this issue?

rajgoesout added a commit to rajgoesout/coAST that referenced this issue Dec 1, 2018
rajgoesout added a commit to rajgoesout/coAST that referenced this issue Dec 1, 2018
@jayvdb jayvdb closed this as completed in #75 Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants