修复事务同步执行删除缓存问题 #23
Open
修复事务同步执行删除缓存问题 #23
+156
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adaex
requested changes
Sep 19, 2025
adaex
requested changes
Sep 27, 2025
| return result | ||
| }) | ||
|
|
||
| if (clearCacheNsps.length > 0) { await this.cache.mDelete(clearCacheNsps) } |
|
|
||
| async getById(id: string, pick = this.columns, trx?: CoaMysql.Transaction, ms = this.ms, force = false) { | ||
| const result = await this.redisCache.warp(this.getCacheNsp('id'), id, async () => await super.getById(id, this.columns, trx), ms, force) | ||
| const result = trx ? await super.getById(id, this.columns, trx) : await this.redisCache.warp(this.getCacheNsp('id'), id, async () => await super.getById(id, this.columns, trx), ms, force) |
There was a problem hiding this comment.
有问题：
1、直接判断是不是 trx 太简单了，一改所有的代码都有影响，我们新加一个 safeTransaction 的目的就是平滑迁移，自由 safeTransaction 的方法才会使用新的逻辑，下面有几个都是一样，都需要改
2、还有一个这个场景的问题需要考量，等你改完再讨论
|
|
||
| protected async deleteCache(ids: string[], dataList: Array<CoaMysql.SafePartial<Scheme>>) { | ||
| async deleteCache(ids: string[], dataList: Array<CoaMysql.SafePartial<Scheme>>, trx?: CoaMysql.Transaction) { | ||
| if (trx && !(trx as any).clearCacheNsps) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.