Rewriting SS Model as a Set of Functions #18
Conversation
Adding OpenMC scripts with functions that create .xml files
…MC_xml.py Adding additional folder to store scripts
Add separate method for parser Co-authored-by: Paul Wilson <[email protected]>
Replacing with individual files that make OpenMC Materials, Geometry, and Model
…Functions/OpenMC_Model/OpenMC_SS_Geometry.py
…nctions/OpenMC_Model/OpenMC_SS_YAML.yaml
…Functions/OpenMC_Model/OpenMC_SS_Material.py
…lit_into_Functions/OpenMC_Model/OpenMC_Source_Tallies_Model.py
|
I've broken up the existing Spherical Shell script into a Materials, Geometry, and a Source/Tallies/Model. The depletion and post-processing will come in subsequent PRs |
anu1217
changed the title
anu1217
changed the title
|
I think I anticipated that this would replace the version in |
|
I'll add the depletion and post-processing scripts here as well since SS_Activation_OpenMC is getting replaced |
…ons/OpenMC_Depletion/SS_Depletion.py
…enMC_SS_YAML.yaml to SphericalShell/Split_into_Functions/OpenMC_SS_YAML.yaml Move YAML to directory above model & depletion
This is being replaced by a set of xml files that make the model, perform depletion, and analyze results
…n/SS_Depletion.py to SphericalShell/OpenMC_Input/Depletion
…enMC_SS_Geometry.py to SphericalShell/OpenMC_Input/Model
…hell/OpenMC_Input/OpenMC_Depletion/SS_Depletion
…/OpenMC_Input/OpenMC_Model/SS_Geometry
…enMC_SS_Material.py to SphericalShell/OpenMC_Input/SS_Material.py
| ''' | ||
| inputs: | ||
| element: elemental symbol of chosen element (str) | ||
| density_dict: dictionary with key = elemental symbol & value = density [g/cm^3] |
There was a problem hiding this comment.
Your docstring doesn't include the geometry info.... but I wonder if that should be done elsewhere. I am guessing this is only necessary for the depletion/activation calculation. Should we do it in a different way to keep the separation of concerns of just making a new material?
There was a problem hiding this comment.
The volume is used for depletion and during post-processing, where flux data is normalized by volume. Calculating the volume separately for both of these might be best for separation of concerns...I think I was trying to avoid having to import the thickness/radius on each occasion
SphericalShell/OpenMC_Output_Processing/SS_Depletion_PostProcessing.py
Outdated
Show resolved
Hide resolved
| nuclide_array = np.append(nuclide_array, nuclide) | ||
|
|
||
| # Remove None element from array initialization | ||
| nuclide_array = [nuc for nuc in nuclide_array if nuc is not None] |
There was a problem hiding this comment.
How do we end up with None in this list/array?
There was a problem hiding this comment.
This comes from initialization of the associated np.ndarray
|
|
||
| # Remove None element from array initialization | ||
| nuclide_array = [nuc for nuc in nuclide_array if nuc is not None] | ||
| return nuclide_array, materials_object, dep_results, time_steps |
There was a problem hiding this comment.
This only returns the materials_object from the last time step, is that intentional/necessary?
There was a problem hiding this comment.
From what I understand, it doesn't matter which time step materials_object is from, as it is only used in conjunction with get_atoms(), which gives nuclide concentration vs. time based on the material the specified nuclide came from. I see the same results if I specify a material id for get_atoms instead of a materials object.
| import numpy as np | ||
| import matplotlib.pyplot as plt | ||
|
|
||
| def extract_nuclides(dep_file_path, time_units, depletable_mat_index) : |
There was a problem hiding this comment.
It seems like the purpose of this is to collect a list of all the nuclides that appear, excluding the list of stable nuclides at beginning of life. Is that right? Do don't seem to actually record/return any data about those nuclides as a function of time.
There was a problem hiding this comment.
This function just stores all the new nuclides that were created (and any unstable ones at the beginning of operation), so that they can be easily retrieved later. The get_atoms method (used in plot_save_data) returns nuclide concentration as a function of time.
SphericalShell/OpenMC_Output_Processing/SS_Depletion_PostProcessing.py
Outdated
Show resolved
Hide resolved
…ssing.py Co-authored-by: Paul Wilson <[email protected]>
…el.py Co-authored-by: Paul Wilson <[email protected]>
Co-authored-by: Paul Wilson <[email protected]>
Co-authored-by: Paul Wilson <[email protected]>
Adding OpenMC scripts with functions that create .xml files