Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning up "TOC Contributors" list #885

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

dims
Copy link
Member

@dims dims commented Jul 27, 2022

Please see #867 for context

Signed-off-by: Davanum Srinivas [email protected]

@dims dims marked this pull request as ready for review July 28, 2022 17:26
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
FAQ.md Outdated Show resolved Hide resolved
@dims dims force-pushed the cleaning-up-toc-contributors-list branch from 4fd5458 to c84142e Compare August 5, 2022 15:21
@dims
Copy link
Member Author

dims commented Aug 5, 2022

Let's give this a week as well - So we merge Aug 12th.

Copy link
Contributor

@TheFoxAtWork TheFoxAtWork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cathyhongzhang
Copy link

LGTM!

Co-authored-by: Emily Fox <[email protected]>
Signed-off-by: Davanum Srinivas <[email protected]>
@dims dims force-pushed the cleaning-up-toc-contributors-list branch from c84142e to 01af8e0 Compare August 15, 2022 15:34
@dims
Copy link
Member Author

dims commented Aug 15, 2022

Squashed and rebased and shipping now!

@dims dims merged commit cd39aa6 into cncf:main Aug 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants