Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update platforms working group time converter link #793

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ryandoyle
Copy link

Use the current date which takes into account any current daylight savings deltas.

Use the current date which takes into account any current daylight savings deltas.

Signed-off-by: Ryan Doyle <[email protected]>
Copy link

Action Required

You are adding or updating English content so please take the following actions for other languages.

  • If you update content, that has corresponding files in other languages, include a note suggesting that users check the English page for the most recent updates in those translated pages.
  • If you add new content under website/content/en there is nothing you need to do.

Copy link

netlify bot commented Jan 14, 2025

Deploy Preview for tag-app-delivery ready!

Name Link
🔨 Latest commit c53a305
🔍 Latest deploy log https://app.netlify.com/sites/tag-app-delivery/deploys/678776bc288fd9000814bfc2
😎 Deploy Preview https://deploy-preview-793--tag-app-delivery.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for noticing and taking action on this! 🚀

However I don't think this change is very sustainable. It will be out if date again in 2 months when day light savings happens again.

I wonder if a link like this makes more sense?

https://www.worldtimebuddy.com/?pl=1&lid=2643743,30,3451190,5391959,5128581,2147714&h=2643743&hf=1

Happy for you to propose a different one but I'm hesitant to update this page to something that will require this level of upkeep.

In addition, we will need this to be edited for all languages as the auto comment says. You can find these pages in the same hierarchy under the website directory.

Thanks for taking this on, it's been a niggle for a long time 🙌

Selects the current day to do the time conversion. Nicer than keeping
this up to date :). Additionally, update all translations to use this.

Signed-off-by: Ryan Doyle <[email protected]>
@ryandoyle
Copy link
Author

Cheers @abangser, thanks for the link, much more sustainable :). I've slightly motified it to select the 4PM time slot and updated all languages

@ryandoyle ryandoyle requested a review from abangser January 15, 2025 08:52
Copy link
Collaborator

@abangser abangser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fantastic! Thanks for reviewing the link and extending to the other languages 🗺️

LGTM and will get someone from the TAG to merge (maybe @GenPage?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants