Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade WP to 6.7 #904

Merged
merged 7 commits into from
Nov 29, 2024
Merged

Upgrade WP to 6.7 #904

merged 7 commits into from
Nov 29, 2024

Conversation

cjyabraham
Copy link
Collaborator

@cjyabraham cjyabraham commented Nov 14, 2024

@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Nov 14, 2024

  1. The egg is slightly different height. Compare this to this.
  2. In some cases the image seems blurry, compare this to this or this with this
  3. Slight shift in image height, see logo on this case study vs this

@cjyabraham
Copy link
Collaborator Author

cjyabraham commented Nov 15, 2024

For (1) and (3), This new instance appears to have this extra user agent stylesheet styles applied to the image:

For (2), a lower-res version of the image appears to be used, compare this to this, which are the versions being downloaded into my desktop browser. No idea why it's doing this, however, since the markup appears to be identical.

For (3), a better res image is used on the PR instance than on the live instance, which is the opposite of in (2).

@cjyabraham
Copy link
Collaborator Author

Note: these differences in image quality/height are only present in Chrome, not in Safari or FF.

cjyabraham and others added 5 commits November 29, 2024 13:36
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
@thetwopct
Copy link
Collaborator

thetwopct commented Nov 29, 2024

In the case of Project Metrics hero image, I think Chrome is lowering the quality due to the loading=lazy applied to it. I have made some changes to how lazy loading is applied or not depending on page/post type. This seems to fix it, or at least it looks better to me now. I think the other issues with the intrinsic size were fixed in 6.7.1. Let me know if you can find any other image problems.

Also includes some fixes for #899

Signed-off-by: James Hunt <[email protected]>
@cjyabraham cjyabraham merged commit e0b9ea7 into main Nov 29, 2024
5 checks passed
@cjyabraham cjyabraham deleted the wp67 branch November 29, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants