-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade WP to 6.7 #904
Upgrade WP to 6.7 #904
Conversation
For (1) and (3), This new instance appears to have this extra user agent stylesheet styles applied to the image: For (2), a lower-res version of the image appears to be used, compare this to this, which are the versions being downloaded into my desktop browser. No idea why it's doing this, however, since the markup appears to be identical. For (3), a better res image is used on the PR instance than on the live instance, which is the opposite of in (2). |
Note: these differences in image quality/height are only present in Chrome, not in Safari or FF. |
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: Chris Abraham <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
Signed-off-by: James Hunt <[email protected]>
In the case of Project Metrics hero image, I think Chrome is lowering the quality due to the loading=lazy applied to it. I have made some changes to how lazy loading is applied or not depending on page/post type. This seems to fix it, or at least it looks better to me now. I think the other issues with the intrinsic size were fixed in 6.7.1. Let me know if you can find any other image problems. Also includes some fixes for #899 |
Signed-off-by: James Hunt <[email protected]>
Dev instance