Migrate playground-utils to ffi_support #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a test run of using the patterns encouraged by mozilla's ffi-support crate (https://docs.rs/ffi-support). I wasn't totally sure how this would go, but it was relatively painless and I'm encouraged by the code. While I was in here I also did some general cleanup on the swift side
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a test run of using the patterns encouraged by mozilla's
ffi-support crate (https://docs.rs/ffi-support).
I wasn't totally sure how this would go, but it was relatively painless
and I'm encouraged by the code.
While I was in here I also did some general cleanup on the swift side
progress on #5 (still need to rework the other library that handles xi stuff)