Canonicalize rotation when testing flattening #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaurav-arya
force-pushed
the
flatten-test
branch
from
84aa8c0 to
82aacea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The corresponding C++ tests for
SpectralConformalParameterization.flattencheck if there exists a valid rotation between the produced flattening and the reference solution, but it seems like this logic might be missing from the tests here (note that thenormalizefunction ingeometry.jscenters and rescales the points, but does not canonicalize rotation). This PR ports over the rotation logic from the C++ test.(The motivation is that my code for https://brickisland.net/ddg-web/assignments/assignment4/index.html would only pass the test with this adjustment. But it's possible that I just missed some instruction that would allow me to pass the original test, e.g. perhaps there is some preferred rotation specified in the assignment spec that I did not notice.)