Skip to content
This repository has been archived by the owner on Mar 10, 2022. It is now read-only.

Commit

Permalink
Merge branch 'master' into 4.0
Browse files Browse the repository at this point in the history
  • Loading branch information
cmtt authored and Matthias Thoemmes committed Nov 27, 2019
2 parents 23314ed + 0e4834d commit d10f63c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
2 changes: 0 additions & 2 deletions lib/gulp-di.js
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ module.exports = (function () {
*/

class GulpDI {

/**
* @constructor
* @param {object} gulp The gulp instance to use
Expand Down Expand Up @@ -264,7 +263,6 @@ module.exports = (function () {
tasks (directory) {
return this.task(readDirectory(normalizePath(parentDir, directory), false));
}

}

/**
Expand Down
2 changes: 1 addition & 1 deletion lib/resolver.js
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ class Resolver {
throw new Error(`Circular: ${entry.key} -> ${key}`);
}
const queuedItem = this.byId(key);
_resolve({ key, dependencies: queuedItem && queuedItem.dependencies || [] }, unresolved);
_resolve({ key, dependencies: (queuedItem && queuedItem.dependencies) || [] }, unresolved);
}

unresolved = _.without(unresolved, entry.key);
Expand Down
4 changes: 2 additions & 2 deletions tasks/examples.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ module.exports = (Package, basePath, chalk, log, gulp, taskInfo, gutil, runningT
*/

console.log(`${Package.name}s location: `, basePath());
console.log(`this file\'s location: ${basePath('tasks', path.basename(__filename))}`);
console.log(`this file's location: ${basePath('tasks', path.basename(__filename))}`);
});

// You can declare multiple gulp tasks in each file.
Expand All @@ -22,7 +22,7 @@ module.exports = (Package, basePath, chalk, log, gulp, taskInfo, gutil, runningT
* Example logging task information from contrib/help.js
*/

console.log(`${Package.name}\'s task information: `);
console.log(`${Package.name}'s task information: `);
console.log(taskInfo);
cb();
});
Expand Down

0 comments on commit d10f63c

Please sign in to comment.