Revert three more Clang patches from hahnjo:revert-clang-patches

[aandvalenzuela]

Testing root-project#13181.

[cmsbuild]

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch cms/master/7f288f1ca8.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.
cms-bot commands are listed here

[aandvalenzuela]

please test for CMSSW_13_2_ROOT6_X

[smuzaffar]

thanks @aandvalenzuela for testing it. By the you do not need to copy the branch, you can use the https://github.com/hahnjo/root/tree/revert-clang-patches branch directly to open PR. This way when author pushes any thing to his/her branch then we also get those change here

[aandvalenzuela]

Thanks @smuzaffar! I tried, but although https://github.com/hahnjo/root fork seems to be public, I could not select it as a head repo:

Not even writing the entire fork name:

Just out of curiosity @hahnjo, do you have any special protection for that?

[hahnjo]

Not that I'm aware of; can you see the "Compare" buttons on https://github.com/hahnjo/root/branches ?

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a2d4/33571/summary.html
COMMIT: b6711ea
CMSSW: CMSSW_13_2_ROOT6_X_2023-07-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/root/179/33571/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun3 had ERRORS
---> test testDataFormatsScoutingRun2 had ERRORS
---> test testUCTUnpacker had ERRORS

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 20 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 15
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3193855
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aandvalenzuela]

Not that I'm aware of; can you see the "Compare" buttons on https://github.com/hahnjo/root/branches ?

Yes! Now I can compare cms/master/7f288f1ca8...hahnjo:root:revert-clang-patches. Mmmm... I wonder why it did not work the other way

[aandvalenzuela]

For CMSSW, tests testDataFormatsScoutingRun2/3 and testUCTUnpacker are also failing in the integration builds.

[cmsbuild]

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a2d4/33632/summary.html
COMMIT: b6711ea
CMSSW: CMSSW_13_2_ROOT6_X_2023-07-10-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/root/179/33632/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

• @cms-sw Update tag for RecoMuon-MuonIdentification to V01-15-00 cmsdist#8588
• @cms-sw Update tag for L1Trigger-L1TMuon to V01-08-00 cmsdist#8587

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a2d4/33632/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-59a2d4/33632/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test testDataFormatsScoutingRun2 had ERRORS
---> test testDataFormatsScoutingRun3 had ERRORS
---> test testUCTUnpacker had ERRORS

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 61 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3193892
• DQMHistoTests: Total failures: 33
• DQMHistoTests: Total nulls: 1743
• DQMHistoTests: Total successes: 3192094
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 207 log files, 159 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aandvalenzuela]

root-project#13181 was completed!