Cling: prevent double release of Transactions, take 2 #154
Conversation
new of a char array might not have the correct alignment to hold a Transaction. Allocate a Transaction itself directly, instead of in-place constructing it in the character array. Each Transaction in the pool is thus constructed through `new Transaction(S)` and destructed through `delete T`, which is nicely symmetrical. The use of `::operator new` and `::operator delete` isn't actually necessary. While I'm at it, improve the assert message's wording.
a cheap way to notice what went wrong in root-project#7657.
Outer RAIIs might still reference the Transaction, and unload is assuming that it owns the transaction and can delete it / put it into the TransactionPool. This fixes root-project#7657 We still need to track ownership as what has happened here (unload of a Transaction held by an RAII) can happen again / elsewhere. This will be addressed by a subsequent PR in master.
|
please test with cms-sw/cmsdist#6778 |
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch cms/master/0aa77ef. @cmsbuild, @smuzaffar, @mrodozov can you please review it and eventually sign? Thanks. |
cmsbuild
added
externals-pending
orp-pending
pending-signatures
tests-pending
requires-external
tests-started
and removed
tests-pending
labels
|
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found errors in the following unit tests: ---> test runtestTqafTopEventProducers had ERRORS ---> test runtestTqafTopHitFit had ERRORS ---> test runtestTqafTopJetCombination had ERRORS ---> test runtestTqafTopEventSelection had ERRORS and more ... RelVals
AddOn Tests
|
|
test parameters:
|
|
please test |
|
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS ---> test runtestTqafTopEventSelection had ERRORS ---> test runtestTqafTopHitFit had ERRORS ---> test runtestTqafTopJetCombination had ERRORS and more ... RelVals
AddOn Tests
|
|
Please test |
|
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found errors in the following unit tests: ---> test runtestTqafTopEventProducers had ERRORS ---> test runtestTqafTopHitFit had ERRORS ---> test runtestTqafTopEventSelection had ERRORS ---> test runtestTqafTopKinFitter had ERRORS and more ... RelVals
AddOn Tests
|
|
please test |
|
-1 Failed Tests: UnitTests RelVals AddOn Unit TestsI found errors in the following unit tests: ---> test runtestPhysicsToolsPatAlgos had ERRORS ---> test runtestTqafTopTools had ERRORS ---> test runtestTqafTopKinFitter had ERRORS ---> test runtestTqafTopEventSelection had ERRORS and more ... RelVals
AddOn Tests
|
3 participants
No description provided.